Renaming parameters for positioning a track cue
authoreric.carlson@apple.com <eric.carlson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 2 Apr 2012 17:10:34 +0000 (17:10 +0000)
committereric.carlson@apple.com <eric.carlson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 2 Apr 2012 17:10:34 +0000 (17:10 +0000)
commitf141a2635f44af4f8f8852539e10f3fe49c79a55
treed57702c9901c6b647ece229446a6b145b1117da2
parent1ea1459851bee32281425758c40b2c01422091b7
Renaming parameters for positioning a track cue
https://bugs.webkit.org/show_bug.cgi?id=78706

Source/WebCore:

Change WebVTT settings identifiers for spec change: D: -> vertical:, L: -> line:,
T: -> position:, S: -> size:, A: -> align:

Reviewed by Sam Weinig.

No new tests, existing tests updated for spec changes.

* html/track/TextTrackCue.cpp:
(WebCore::verticalGrowingLeftKeyword): Drive-by change to improve readability.
(WebCore::TextTrackCue::settingName): New, parse the settings keyword.
(WebCore::TextTrackCue::parseSettings): Update to match the current spec.
* html/track/TextTrackCue.h:

* html/track/WebVTTParser.h:
(WebCore::WebVTTParser::isValidSettingDelimiter): New.

LayoutTests:

Reviewed by Sam Weinig.

* media/track/captions-webvtt/missed-cues.vtt:
* media/track/captions-webvtt/sorted-dispatch.vtt:
* media/track/captions-webvtt/tc005-default-styles.vtt:
* media/track/captions-webvtt/tc014-alignment-bad.vtt:
* media/track/captions-webvtt/tc014-alignment-ltr.vtt:
* media/track/captions-webvtt/tc014-alignment.vtt:
* media/track/captions-webvtt/tc015-positioning-bad.vtt:
* media/track/captions-webvtt/tc015-positioning-ltr.vtt:
* media/track/captions-webvtt/tc015-positioning.vtt:
* media/track/captions-webvtt/tc016-align-positioning-bad.vtt:
* media/track/captions-webvtt/tc016-align-positioning.vtt:
* media/track/captions-webvtt/tc017-line-position-bad.vtt:
* media/track/captions-webvtt/tc017-line-position.vtt:
* media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt:
* media/track/captions-webvtt/tc018-align-text-line-position.vtt:
* media/track/captions-webvtt/tc019-cue-size-bad.vtt:
* media/track/captions-webvtt/tc019-cue-size.vtt:
* media/track/captions-webvtt/tc020-cue-size-align-bad.vtt:
* media/track/captions-webvtt/tc020-cue-size-align.vtt:
* media/track/captions-webvtt/tc021-valign-bad.vtt:
* media/track/captions-webvtt/tc021-valign-ltr.vtt:
* media/track/captions-webvtt/tc021-valign.vtt:
* media/track/captions-webvtt/tc022-entities-wrong.vtt:
* media/track/captions-webvtt/tc022-entities.vtt:
* media/track/captions-webvtt/tc023-markup-bad.vtt:
* media/track/captions-webvtt/tc023-markup.vtt:
* media/track/captions-webvtt/tc024-timestamp-bad.vtt:
* media/track/captions-webvtt/tc024-timestamp.vtt:
* media/track/captions-webvtt/tc025-class-bad.vtt:
* media/track/captions-webvtt/tc025-class.vtt:
* media/track/captions-webvtt/tc026-voice-bad.vtt:
* media/track/captions-webvtt/tc026-voice.vtt:
* media/track/captions-webvtt/tc027-empty-cue.vtt:
* media/track/captions-webvtt/tc028-unsupported-markup.vtt:
    Update settings for spec change.

* media/track/captions-webvtt/tc013-settings-bad-separation.vtt:
* media/track/captions-webvtt/tc013-settings.vtt:
* media/track/track-webvtt-tc013-settings-expected.txt:
* media/track/track-webvtt-tc013-settings.html:
    Update test and results to skip illegal settings delimiters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
43 files changed:
LayoutTests/ChangeLog
LayoutTests/media/track/captions-webvtt/missed-cues.vtt
LayoutTests/media/track/captions-webvtt/sorted-dispatch.vtt
LayoutTests/media/track/captions-webvtt/tc005-default-styles.vtt
LayoutTests/media/track/captions-webvtt/tc013-settings-bad-separation.vtt
LayoutTests/media/track/captions-webvtt/tc013-settings.vtt
LayoutTests/media/track/captions-webvtt/tc014-alignment-bad.vtt
LayoutTests/media/track/captions-webvtt/tc014-alignment-ltr.vtt
LayoutTests/media/track/captions-webvtt/tc014-alignment.vtt
LayoutTests/media/track/captions-webvtt/tc015-positioning-bad.vtt
LayoutTests/media/track/captions-webvtt/tc015-positioning-ltr.vtt
LayoutTests/media/track/captions-webvtt/tc015-positioning.vtt
LayoutTests/media/track/captions-webvtt/tc016-align-positioning-bad.vtt
LayoutTests/media/track/captions-webvtt/tc016-align-positioning.vtt
LayoutTests/media/track/captions-webvtt/tc017-line-position-bad.vtt
LayoutTests/media/track/captions-webvtt/tc017-line-position.vtt
LayoutTests/media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt
LayoutTests/media/track/captions-webvtt/tc018-align-text-line-position.vtt
LayoutTests/media/track/captions-webvtt/tc019-cue-size-bad.vtt
LayoutTests/media/track/captions-webvtt/tc019-cue-size.vtt
LayoutTests/media/track/captions-webvtt/tc020-cue-size-align-bad.vtt
LayoutTests/media/track/captions-webvtt/tc020-cue-size-align.vtt
LayoutTests/media/track/captions-webvtt/tc021-valign-bad.vtt
LayoutTests/media/track/captions-webvtt/tc021-valign-ltr.vtt
LayoutTests/media/track/captions-webvtt/tc021-valign.vtt
LayoutTests/media/track/captions-webvtt/tc022-entities-wrong.vtt
LayoutTests/media/track/captions-webvtt/tc022-entities.vtt
LayoutTests/media/track/captions-webvtt/tc023-markup-bad.vtt
LayoutTests/media/track/captions-webvtt/tc023-markup.vtt
LayoutTests/media/track/captions-webvtt/tc024-timestamp-bad.vtt
LayoutTests/media/track/captions-webvtt/tc024-timestamp.vtt
LayoutTests/media/track/captions-webvtt/tc025-class-bad.vtt
LayoutTests/media/track/captions-webvtt/tc025-class.vtt
LayoutTests/media/track/captions-webvtt/tc026-voice-bad.vtt
LayoutTests/media/track/captions-webvtt/tc026-voice.vtt
LayoutTests/media/track/captions-webvtt/tc027-empty-cue.vtt
LayoutTests/media/track/captions-webvtt/tc028-unsupported-markup.vtt
LayoutTests/media/track/track-webvtt-tc013-settings-expected.txt
LayoutTests/media/track/track-webvtt-tc013-settings.html
Source/WebCore/ChangeLog
Source/WebCore/html/track/TextTrackCue.cpp
Source/WebCore/html/track/TextTrackCue.h
Source/WebCore/html/track/WebVTTParser.h