Source/WebCore: REGRESSION(r115654): PDFs come up blank
authorjaphet@chromium.org <japhet@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 2 May 2012 01:23:10 +0000 (01:23 +0000)
committerjaphet@chromium.org <japhet@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 2 May 2012 01:23:10 +0000 (01:23 +0000)
commite95875463f3f283c3729c15da5b99501886aa234
tree497cf5678341a070e337124c2a0ad2b3406f50bd
parentb7d0418898af336ef3a0d7d06304fea506aecdd0
Source/WebCore: REGRESSION(r115654): PDFs come up blank
https://bugs.webkit.org/show_bug.cgi?id=85275

Reviewed by Alexey Proskuryakov.

Test: http/tests/loading/pdf-commit-load-callbacks.html

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading): The load needs to be
    committed before we call finishedLoading on the
    FrameLoaderClient.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted): We're guaranteeing
    that receivedFirstData() will be called other ways (namely,
    DocumentLoader won't finish without doing so). This call now
    causes custom representations to double-commit, which is bad.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=85275.

Reviewed by Alexey Proskuryakov.

* http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
* http/tests/loading/pdf-commit-load-callbacks.html: Added.
* platform/chromium/http/tests/loading: Added.
* platform/chromium/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
* platform/wk2/Skipped: New test requires layoutTestController.dumpResourceLoadCallbacks(),
    which isn't support for wk2 yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/http/tests/loading/pdf-commit-load-callbacks-expected.txt [new file with mode: 0644]
LayoutTests/http/tests/loading/pdf-commit-load-callbacks.html [new file with mode: 0644]
LayoutTests/platform/chromium/http/tests/loading/pdf-commit-load-callbacks-expected.txt [new file with mode: 0644]
LayoutTests/platform/wk2/Skipped
Source/WebCore/ChangeLog
Source/WebCore/loader/DocumentLoader.cpp
Source/WebCore/loader/FrameLoader.cpp