2007-07-08 Mitz Pettel <mitz@webkit.org>
authorbdash <bdash@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 8 Jul 2007 09:54:42 +0000 (09:54 +0000)
committerbdash <bdash@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 8 Jul 2007 09:54:42 +0000 (09:54 +0000)
commite55558e091cf11f743a42daa76ffc174f196b778
tree59f1d5349023948fd9e2175da8036b213fb852a8
parent459be3861b324d984e727b706e4750e2c38b4644
2007-07-08  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14221
          Repro crash (ASSERTION FAILED: oldText in RenderBlock::updateFirstLetter() during relayout of :before content with first-letter style)

        Test: fast/css-generated-content/before-with-first-letter.html

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::updateBeforeAfterContentForContainer): If a child
        of the existing 'before' container is not text, do not assume that it is an
        image, since it can also be an inline wrapping a first-letter. In that case,
        do not update its style (so in particular, keep it a FIRST_LETTER type style)
        and leave it to updateFirstLetter() to take care of.

2007-07-08  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=14221
          Repro crash (ASSERTION FAILED: oldText in RenderBlock::updateFirstLetter() during relayout of :before content with first-letter style)

        * fast/css-generated-content/before-with-first-letter-expected.checksum: Added.
        * fast/css-generated-content/before-with-first-letter-expected.png: Added.
        * fast/css-generated-content/before-with-first-letter-expected.txt: Added.
        * fast/css-generated-content/before-with-first-letter.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/css-generated-content/before-with-first-letter-expected.checksum [new file with mode: 0644]
LayoutTests/fast/css-generated-content/before-with-first-letter-expected.png [new file with mode: 0644]
LayoutTests/fast/css-generated-content/before-with-first-letter-expected.txt [new file with mode: 0644]
LayoutTests/fast/css-generated-content/before-with-first-letter.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/rendering/RenderContainer.cpp