Unreviewed, rolling out r116498.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 May 2012 21:12:02 +0000 (21:12 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 May 2012 21:12:02 +0000 (21:12 +0000)
commitde885053fdf367c5627b3d1975a4726c7b6d7ac9
treea362cb2d9427c28d925ef9f6360ad3178d44be25
parentd60b8db2ef2571064b019393e66ddd4922ea5c60
Unreviewed, rolling out r116498.
http://trac.webkit.org/changeset/116498
https://bugs.webkit.org/show_bug.cgi?id=86251

Causes crashes in major sites and security issues (Requested
by schenney on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::addChild):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::willBeDestroyed):
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):
* rendering/svg/RenderSVGText.cpp:
(WebCore::recursiveUpdateLayoutAttributes):
(WebCore::RenderSVGText::layoutAttributesChanged):
(WebCore::RenderSVGText::layoutAttributesWillBeDestroyed):
(WebCore::RenderSVGText::invalidateTextPositioningElements):
(WebCore::recursiveUpdateScaledFont):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):
(WebCore):
* rendering/svg/RenderSVGText.h:
(RenderSVGText):
(WebCore::RenderSVGText::layoutAttributes):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):

LayoutTests:

* svg/text/add-tspan-position-bug-expected.html: Removed.
* svg/text/add-tspan-position-bug.html: Removed.
* svg/text/modify-tspan-position-bug-expected.html: Removed.
* svg/text/modify-tspan-position-bug.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
12 files changed:
LayoutTests/ChangeLog
LayoutTests/svg/text/add-tspan-position-bug-expected.html [deleted file]
LayoutTests/svg/text/add-tspan-position-bug.html [deleted file]
LayoutTests/svg/text/modify-tspan-position-bug-expected.html [deleted file]
LayoutTests/svg/text/modify-tspan-position-bug.html [deleted file]
Source/WebCore/ChangeLog
Source/WebCore/rendering/svg/RenderSVGInline.cpp
Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
Source/WebCore/rendering/svg/RenderSVGText.cpp
Source/WebCore/rendering/svg/RenderSVGText.h
Source/WebCore/rendering/svg/SVGRootInlineBox.cpp
Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp