Web Inspector: Spacebar to start recording should not cause system beep
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 27 Oct 2015 00:08:21 +0000 (00:08 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 27 Oct 2015 00:08:21 +0000 (00:08 +0000)
commitdb7ce46f9033768132a1c411cefb95691a22591a
tree7cf48497434357f4e61ab4114cbd17df70718ab8
parentb272286cdc556124997ed82ff31a80df5195c1d5
Web Inspector: Spacebar to start recording should not cause system beep
https://bugs.webkit.org/show_bug.cgi?id=150573

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-26
Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype._toggleRecordingOnSpacebar):
(WebInspector.TimelineSidebarPanel.prototype._toggleNewRecordingOnSpacebar):
The keyboard shortcuts do not implicitly prevent default because they may bail.
So in cases where they do handle the key, prevent default to prevent system beeps.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js