Web Inspector: Debugger: support emulateUserGesture parameter in Debugger.evaluateOnC...
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 1 Aug 2019 05:19:27 +0000 (05:19 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 1 Aug 2019 05:19:27 +0000 (05:19 +0000)
commitdaf68eed15f6711e83b357fd0219c3671760d2af
tree7de0df8bb754513af40d76bfe4268da7e41b9c99
parentfe30f761c2b85dd91f27111febe096db4c10bb5a
Web Inspector: Debugger: support emulateUserGesture parameter in Debugger.evaluateOnCallFrame
https://bugs.webkit.org/show_bug.cgi?id=200272

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

When paused, evaluating in the console should still respect the "Emulate User Gesture" checkbox.

* inspector/protocol/Debugger.json:
* inspector/agents/InspectorDebuggerAgent.h:
* inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::evaluateOnCallFrame):

Source/WebCore:

When paused, evaluating in the console should still respect the "Emulate User Gesture" checkbox.

Tests: inspector/debugger/evaluateOnCallFrame-emulateUserGesture.html
       inspector/debugger/evaluateOnCallFrame-emulateUserGesture-userIsInteracting.html

* inspector/agents/page/PageDebuggerAgent.h:
* inspector/agents/page/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::evaluateOnCallFrame): Added.

Source/WebInspectorUI:

When paused, evaluating in the console should still respect the "Emulate User Gesture" checkbox.

* UserInterface/Controllers/RuntimeManager.js:
(WI.RuntimeManager.prototype.evaluateInInspectedWindow):

* UserInterface/Protocol/Legacy/13.0/InspectorBackendCommands.js:
* Versions/Inspector-iOS-13.0.json:

LayoutTests:

* inspector/debugger/evaluateOnCallFrame-emulateUserGesture.html: Added.
* inspector/debugger/evaluateOnCallFrame-emulateUserGesture-expected.txt: Added.
* inspector/debugger/evaluateOnCallFrame-emulateUserGesture-userIsInteracting.html: Added.
* inspector/debugger/evaluateOnCallFrame-emulateUserGesture-userIsInteracting-expected.txt: Added.
* TestExpectations:
* platform/wk2/TestExpectations:

* inspector/runtime/evaluate-emulateUserGesture.html: Added.
* inspector/runtime/evaluate-emulateUserGesture-expected.txt: Added.
* inspector/runtime/evaluate-emulateUserGesture-userIsInteracting.html: Added.
* inspector/runtime/evaluate-emulateUserGesture-userIsInteracting-expected.txt: Added.
* inspector/runtime/evaluate-userGestureEmulation.html: Deleted.
* inspector/runtime/evaluate-userGestureEmulation-expected.txt: Deleted.
* inspector/runtime/evaluate-userGestureEmulation-userIsInteracting.html: Deleted.
* inspector/runtime/evaluate-userGestureEmulation-userIsInteracting-expected.txt: Deleted.
Rename tests from "userGestureEmulation" to "emulateUserGesture" to match the parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
22 files changed:
LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/inspector/debugger/evaluateOnCallFrame-emulateUserGesture-expected.txt [new file with mode: 0644]
LayoutTests/inspector/debugger/evaluateOnCallFrame-emulateUserGesture-userIsInteracting-expected.txt [new file with mode: 0644]
LayoutTests/inspector/debugger/evaluateOnCallFrame-emulateUserGesture-userIsInteracting.html [new file with mode: 0644]
LayoutTests/inspector/debugger/evaluateOnCallFrame-emulateUserGesture.html [new file with mode: 0644]
LayoutTests/inspector/runtime/evaluate-emulateUserGesture-expected.txt [moved from LayoutTests/inspector/runtime/evaluate-userGestureEmulation-expected.txt with 76% similarity]
LayoutTests/inspector/runtime/evaluate-emulateUserGesture-userIsInteracting-expected.txt [moved from LayoutTests/inspector/runtime/evaluate-userGestureEmulation-userIsInteracting-expected.txt with 75% similarity]
LayoutTests/inspector/runtime/evaluate-emulateUserGesture-userIsInteracting.html [moved from LayoutTests/inspector/runtime/evaluate-userGestureEmulation-userIsInteracting.html with 97% similarity]
LayoutTests/inspector/runtime/evaluate-emulateUserGesture.html [moved from LayoutTests/inspector/runtime/evaluate-userGestureEmulation.html with 98% similarity]
LayoutTests/platform/wk2/TestExpectations
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp
Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.h
Source/JavaScriptCore/inspector/protocol/Debugger.json
Source/WebCore/ChangeLog
Source/WebCore/inspector/agents/page/PageDebuggerAgent.cpp
Source/WebCore/inspector/agents/page/PageDebuggerAgent.h
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js
Source/WebInspectorUI/UserInterface/Protocol/Legacy/13.0/InspectorBackendCommands.js
Source/WebInspectorUI/Versions/Inspector-iOS-13.0.json