MediaStream id should be equal to msid
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 11 Apr 2017 17:06:53 +0000 (17:06 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 11 Apr 2017 17:06:53 +0000 (17:06 +0000)
commitda34487d34db410b8463a1501efbaa4554b6043d
treea2e70be1628fa99b90cc1614be2cc194096b4648
parente5a48ea68548928ffcd222fc67446c1beeff869a
MediaStream id should be equal to msid
https://bugs.webkit.org/show_bug.cgi?id=170712

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-11
Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

* web-platform-tests/webrtc/datachannel-emptystring-expected.txt:
* web-platform-tests/webrtc/no-media-call-expected.txt:
* web-platform-tests/webrtc/promises-call-expected.txt:
* web-platform-tests/webrtc/rtcpeerconnection/setRemoteDescription-expected.txt:

Source/WebCore:

Covered by rebased tests.

Setting MediaStream id to libwebrtc mediastream label.
Refactoring to use more Ref<> in MediaStream code.

Making PeerConnection use the libwebrtc backend by default for layout tests instead of the mock.

* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::create):
(WebCore::createTrackPrivateVector):
(WebCore::MediaStream::MediaStream):
* Modules/mediastream/MediaStream.h:
* Modules/mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::lookUp):
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::allow):
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::mediaStreamFromRTCStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack):
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load):
* platform/graphics/MediaPlayer.h:
* platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::MediaStreamPrivate):
* platform/mediastream/MediaStreamPrivate.h:
(WebCore::MediaStreamPrivate::create):
* testing/Internals.cpp:
(WebCore::Internals::Internals):

LayoutTests:

Removing no longer needed/Adding needed calls to useMockRTCPeerConnectionFactory.

* fast/mediastream/RTCPeerConnection-inspect-answer.html:
* fast/mediastream/RTCPeerConnection-inspect-offer.html:
* fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html:
* fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html:
* fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html:
* fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html:
* fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html:
* webrtc/audio-peer-connection-webaudio.html:
* webrtc/audio-replace-track.html:
* webrtc/connection-state.html:
* webrtc/datachannel/basic.html:
* webrtc/datachannel/bufferedAmountLowThreshold.html:
* webrtc/datachannel/datachannel-gc.html:
* webrtc/datachannel/datachannel-stats.html:
* webrtc/datachannel/filter-ice-candidate.html:
* webrtc/ephemeral-certificates-and-cnames.html:
* webrtc/libwebrtc/descriptionGetters.html:
* webrtc/negotiatedneeded-event-addStream.html:
* webrtc/no-port-zero-in-upd-candidates.html:
* webrtc/peer-connection-audio-mute.html:
* webrtc/peer-connection-audio-mute2.html:
* webrtc/peer-connection-remote-audio-mute.html:
* webrtc/peer-connection-remote-audio-mute2.html:
* webrtc/release-after-getting-track.html:
* webrtc/video-disabled-black.html:
* webrtc/video-getParameters.html:
* webrtc/video-mediastreamtrack-stats.html:
* webrtc/video-mute.html:
* webrtc/video-remote-mute.html:
* webrtc/video-replace-track-to-null.html:
* webrtc/video-replace-track.html:
* webrtc/video-stats.html:
* webrtc/video-with-receiver.html:
* webrtc/video.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@215238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
53 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/mediastream/RTCPeerConnection-inspect-answer.html
LayoutTests/fast/mediastream/RTCPeerConnection-inspect-offer.html
LayoutTests/fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html
LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html
LayoutTests/fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html
LayoutTests/fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html
LayoutTests/fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html
LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/webrtc/datachannel-emptystring-expected.txt
LayoutTests/imported/w3c/web-platform-tests/webrtc/no-media-call-expected.txt
LayoutTests/imported/w3c/web-platform-tests/webrtc/promises-call-expected.txt
LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/setRemoteDescription-expected.txt
LayoutTests/webrtc/audio-peer-connection-webaudio.html
LayoutTests/webrtc/audio-replace-track.html
LayoutTests/webrtc/connection-state.html
LayoutTests/webrtc/datachannel/basic.html
LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-expected.txt
LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold.html
LayoutTests/webrtc/datachannel/datachannel-gc.html
LayoutTests/webrtc/datachannel/datachannel-stats.html
LayoutTests/webrtc/datachannel/filter-ice-candidate.html
LayoutTests/webrtc/ephemeral-certificates-and-cnames.html
LayoutTests/webrtc/libwebrtc/descriptionGetters.html
LayoutTests/webrtc/negotiatedneeded-event-addStream.html
LayoutTests/webrtc/no-port-zero-in-upd-candidates.html
LayoutTests/webrtc/peer-connection-audio-mute.html
LayoutTests/webrtc/peer-connection-audio-mute2.html
LayoutTests/webrtc/peer-connection-remote-audio-mute.html
LayoutTests/webrtc/peer-connection-remote-audio-mute2.html
LayoutTests/webrtc/release-after-getting-track.html
LayoutTests/webrtc/video-disabled-black.html
LayoutTests/webrtc/video-getParameters.html
LayoutTests/webrtc/video-mediastreamtrack-stats.html
LayoutTests/webrtc/video-mute.html
LayoutTests/webrtc/video-remote-mute.html
LayoutTests/webrtc/video-replace-track-to-null.html
LayoutTests/webrtc/video-replace-track.html
LayoutTests/webrtc/video-stats.html
LayoutTests/webrtc/video-with-receiver.html
LayoutTests/webrtc/video.html
Source/WebCore/ChangeLog
Source/WebCore/Modules/mediastream/MediaStream.cpp
Source/WebCore/Modules/mediastream/MediaStream.h
Source/WebCore/Modules/mediastream/MediaStreamRegistry.cpp
Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h
Source/WebCore/platform/graphics/MediaPlayer.cpp
Source/WebCore/platform/graphics/MediaPlayer.h
Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp
Source/WebCore/platform/mediastream/MediaStreamPrivate.h
Source/WebCore/testing/Internals.cpp