REGRESSION: ( r246394 ) webgpu/whlsl-buffer-fragment.html and webgpu/whlsl-buffer...
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 26 Jun 2019 19:35:26 +0000 (19:35 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 26 Jun 2019 19:35:26 +0000 (19:35 +0000)
commitda09eea2ccbaa1fe87f346f664d4b0b1cabd0da0
tree912b366465681691c007cb7fdec6c95aa28b86d7
parent75abc307e37168fa5367357085bf7270e3204c86
REGRESSION: ( r246394 ) webgpu/whlsl-buffer-fragment.html and webgpu/whlsl-buffer-vertex.html are failing
https://bugs.webkit.org/show_bug.cgi?id=199012

Reviewed by Saam Barati.

Source/WebCore:

* platform/graphics/gpu/cocoa/GPUDeviceMetal.mm:
(WebCore::isAcceptableDevice):
(WebCore::GPUDevice::tryCreate):

Source/WTF:

* wtf/Platform.h:

LayoutTests:

Make the tests still pass if the machine doesn't support WebGPU.

* webgpu/adapter-options-expected.txt: Removed.
* webgpu/adapter-options.html: Removed.
* webgpu/bind-groups.html:
* webgpu/blend-color-triangle-strip-expected.html:
* webgpu/blend-color-triangle-strip.html:
* webgpu/blend-triangle-strip-expected.html:
* webgpu/blend-triangle-strip.html:
* webgpu/blit-commands-expected.html:
* webgpu/blit-commands.html:
* webgpu/buffer-command-buffer-races-expected.html:
* webgpu/buffer-command-buffer-races.html:
* webgpu/color-write-mask-triangle-strip-expected.html:
* webgpu/color-write-mask-triangle-strip.html:
* webgpu/command-buffers.html:
* webgpu/depth-enabled-triangle-strip-expected.html:
* webgpu/depth-enabled-triangle-strip.html:
* webgpu/draw-indexed-triangles-expected.html:
* webgpu/draw-indexed-triangles.html:
* webgpu/js/create-worker-device.js: Removed.
* webgpu/js/webgpu-functions.js:
(drawWhiteSquareOnBlueBackgroundInSoftware):
(drawGreenSquareInSoftware):
(drawGreenAndBlueCheckerboardInSoftware):
(async.mapWriteDataToBuffer):
* webgpu/map-read-buffers.html:
* webgpu/map-write-buffers.html:
* webgpu/pipeline-layouts.html:
* webgpu/propertyresolver/ander-abstract-lvalue-expected.html:
* webgpu/propertyresolver/ander-abstract-lvalue.html:
* webgpu/propertyresolver/ander-expected.html:
* webgpu/propertyresolver/ander-lvalue-3-levels-expected.html:
* webgpu/propertyresolver/ander-lvalue-3-levels.html:
* webgpu/propertyresolver/ander-lvalue-expected.html:
* webgpu/propertyresolver/ander-lvalue.html:
* webgpu/propertyresolver/ander.html:
* webgpu/propertyresolver/getter-expected.html:
* webgpu/propertyresolver/getter.html:
* webgpu/propertyresolver/indexer-ander-abstract-lvalue-expected.html:
* webgpu/propertyresolver/indexer-ander-abstract-lvalue.html:
* webgpu/propertyresolver/indexer-ander-expected.html:
* webgpu/propertyresolver/indexer-ander-lvalue-3-levels-expected.html:
* webgpu/propertyresolver/indexer-ander-lvalue-3-levels.html:
* webgpu/propertyresolver/indexer-ander-lvalue-expected.html:
* webgpu/propertyresolver/indexer-ander-lvalue.html:
* webgpu/propertyresolver/indexer-ander.html:
* webgpu/propertyresolver/indexer-getter-expected.html:
* webgpu/propertyresolver/indexer-getter.html:
* webgpu/propertyresolver/indexer-setter-abstract-lvalue-3-levels-expected.html:
* webgpu/propertyresolver/indexer-setter-abstract-lvalue-3-levels.html:
* webgpu/propertyresolver/indexer-setter-abstract-lvalue-expected.html:
* webgpu/propertyresolver/indexer-setter-abstract-lvalue.html:
* webgpu/propertyresolver/indexer-setter-expected.html:
* webgpu/propertyresolver/indexer-setter-lvalue-expected.html:
* webgpu/propertyresolver/indexer-setter-lvalue.html:
* webgpu/propertyresolver/indexer-setter.html:
* webgpu/propertyresolver/setter-abstract-lvalue-3-levels-expected.html:
* webgpu/propertyresolver/setter-abstract-lvalue-3-levels.html:
* webgpu/propertyresolver/setter-abstract-lvalue-expected.html:
* webgpu/propertyresolver/setter-abstract-lvalue.html:
* webgpu/propertyresolver/setter-lvalue-expected.html:
* webgpu/propertyresolver/setter-lvalue.html:
* webgpu/queue-creation.html:
* webgpu/render-command-encoding.html:
* webgpu/render-pipelines.html:
* webgpu/shader-modules.html:
* webgpu/simple-triangle-strip-expected.html:
* webgpu/simple-triangle-strip.html:
* webgpu/texture-triangle-strip-expected.html:
* webgpu/texture-triangle-strip.html:
* webgpu/textures-textureviews.html:
* webgpu/vertex-buffer-triangle-strip-expected.html:
* webgpu/vertex-buffer-triangle-strip.html:
* webgpu/viewport-scissor-rect-triangle-strip-expected.html:
* webgpu/viewport-scissor-rect-triangle-strip.html:
* webgpu/webgpu-enabled-expected.txt: Removed.
* webgpu/webgpu-enabled-in-worker-expected.txt: Removed.
* webgpu/webgpu-enabled-in-worker.html: Removed.
* webgpu/webgpu-enabled.html: Removed.
* webgpu/whlsl-arbitrary-vertex-attribute-locations-expected.html:
* webgpu/whlsl-arbitrary-vertex-attribute-locations.html:
* webgpu/whlsl-buffer-fragment-expected.html:
* webgpu/whlsl-buffer-fragment.html:
* webgpu/whlsl-buffer-length-expected.txt:
* webgpu/whlsl-buffer-length.html:
* webgpu/whlsl-buffer-vertex-expected.html:
* webgpu/whlsl-buffer-vertex.html:
* webgpu/whlsl-checker-should-set-type-of-read-modify-write-variables-expected.txt:
* webgpu/whlsl-checker-should-set-type-of-read-modify-write-variables.html:
* webgpu/whlsl-compute-expected.txt:
* webgpu/whlsl-compute.html:
* webgpu/whlsl-dereference-pointer-should-type-check-expected.html:
* webgpu/whlsl-dereference-pointer-should-type-check.html:
* webgpu/whlsl-do-while-loop-break-expected.html:
* webgpu/whlsl-do-while-loop-break.html:
* webgpu/whlsl-do-while-loop-continue-expected.html:
* webgpu/whlsl-do-while-loop-continue.html:
* webgpu/whlsl-do-while-loop-expected.html:
* webgpu/whlsl-do-while-loop.html:
* webgpu/whlsl-dont-crash-parsing-enum-expected.html:
* webgpu/whlsl-dont-crash-parsing-enum.html:
* webgpu/whlsl-dot-expressions-expected.html:
* webgpu/whlsl-dot-expressions.html:
* webgpu/whlsl-duplicate-types-should-not-produce-duplicate-ctors-expected.txt:
* webgpu/whlsl-duplicate-types-should-not-produce-duplicate-ctors.html:
* webgpu/whlsl-ensure-proper-variable-lifetime-2-expected.html:
* webgpu/whlsl-ensure-proper-variable-lifetime-2.html:
* webgpu/whlsl-ensure-proper-variable-lifetime-3-expected.html:
* webgpu/whlsl-ensure-proper-variable-lifetime-3.html:
* webgpu/whlsl-ensure-proper-variable-lifetime-expected.html:
* webgpu/whlsl-ensure-proper-variable-lifetime.html:
* webgpu/whlsl-expected.html:
* webgpu/whlsl-loops-break-expected.html:
* webgpu/whlsl-loops-break.html:
* webgpu/whlsl-loops-continue-expected.html:
* webgpu/whlsl-loops-continue.html:
* webgpu/whlsl-loops-expected.html:
* webgpu/whlsl-loops.html:
* webgpu/whlsl-matrix-2-expected.txt:
* webgpu/whlsl-matrix-2.html:
* webgpu/whlsl-matrix-expected.txt:
* webgpu/whlsl-matrix.html:
* webgpu/whlsl-nested-dot-expression-rvalue-expected.html:
* webgpu/whlsl-nested-dot-expression-rvalue.html:
* webgpu/whlsl-nested-loop-expected.html:
* webgpu/whlsl-nested-loop.html:
* webgpu/whlsl-null-dereference-expected.txt:
* webgpu/whlsl-null-dereference.html:
* webgpu/whlsl-oob-access-expected.txt:
* webgpu/whlsl-oob-access.html:
* webgpu/whlsl-read-modify-write-high-zombies-expected.txt:
* webgpu/whlsl-read-modify-write-high-zombies.html:
* webgpu/whlsl-return-local-variable-expected.html:
* webgpu/whlsl-return-local-variable.html:
* webgpu/whlsl-store-to-property-updates-properly-expected.html:
* webgpu/whlsl-store-to-property-updates-properly.html:
* webgpu/whlsl-textures-getdimensions-expected.txt:
* webgpu/whlsl-textures-getdimensions.html:
* webgpu/whlsl-textures-load-expected.html:
* webgpu/whlsl-textures-load.html:
* webgpu/whlsl-textures-sample-expected.html:
* webgpu/whlsl-textures-sample.html:
* webgpu/whlsl-while-loop-break-expected.html:
* webgpu/whlsl-while-loop-break.html:
* webgpu/whlsl-while-loop-continue-expected.html:
* webgpu/whlsl-while-loop-continue.html:
* webgpu/whlsl-zero-initialize-values-2-expected.html:
* webgpu/whlsl-zero-initialize-values-2.html:
* webgpu/whlsl-zero-initialize-values-expected.html:
* webgpu/whlsl-zero-initialize-values.html:
* webgpu/whlsl.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
159 files changed:
LayoutTests/ChangeLog
LayoutTests/webgpu/adapter-options-expected.txt [deleted file]
LayoutTests/webgpu/adapter-options.html [deleted file]
LayoutTests/webgpu/bind-groups.html
LayoutTests/webgpu/blend-color-triangle-strip-expected.html
LayoutTests/webgpu/blend-color-triangle-strip.html
LayoutTests/webgpu/blend-triangle-strip-expected.html
LayoutTests/webgpu/blend-triangle-strip.html
LayoutTests/webgpu/blit-commands-expected.html
LayoutTests/webgpu/blit-commands.html
LayoutTests/webgpu/buffer-command-buffer-races-expected.html
LayoutTests/webgpu/buffer-command-buffer-races.html
LayoutTests/webgpu/color-write-mask-triangle-strip-expected.html
LayoutTests/webgpu/color-write-mask-triangle-strip.html
LayoutTests/webgpu/command-buffers.html
LayoutTests/webgpu/depth-enabled-triangle-strip-expected.html
LayoutTests/webgpu/depth-enabled-triangle-strip.html
LayoutTests/webgpu/draw-indexed-triangles-expected.html
LayoutTests/webgpu/draw-indexed-triangles.html
LayoutTests/webgpu/js/create-worker-device.js [deleted file]
LayoutTests/webgpu/js/webgpu-functions.js
LayoutTests/webgpu/map-read-buffers.html
LayoutTests/webgpu/map-write-buffers.html
LayoutTests/webgpu/pipeline-layouts.html
LayoutTests/webgpu/propertyresolver/ander-abstract-lvalue-expected.html
LayoutTests/webgpu/propertyresolver/ander-abstract-lvalue.html
LayoutTests/webgpu/propertyresolver/ander-expected.html
LayoutTests/webgpu/propertyresolver/ander-lvalue-3-levels-expected.html
LayoutTests/webgpu/propertyresolver/ander-lvalue-3-levels.html
LayoutTests/webgpu/propertyresolver/ander-lvalue-expected.html
LayoutTests/webgpu/propertyresolver/ander-lvalue.html
LayoutTests/webgpu/propertyresolver/ander.html
LayoutTests/webgpu/propertyresolver/getter-expected.html
LayoutTests/webgpu/propertyresolver/getter.html
LayoutTests/webgpu/propertyresolver/indexer-ander-abstract-lvalue-expected.html
LayoutTests/webgpu/propertyresolver/indexer-ander-abstract-lvalue.html
LayoutTests/webgpu/propertyresolver/indexer-ander-expected.html
LayoutTests/webgpu/propertyresolver/indexer-ander-lvalue-3-levels-expected.html
LayoutTests/webgpu/propertyresolver/indexer-ander-lvalue-3-levels.html
LayoutTests/webgpu/propertyresolver/indexer-ander-lvalue-expected.html
LayoutTests/webgpu/propertyresolver/indexer-ander-lvalue.html
LayoutTests/webgpu/propertyresolver/indexer-ander.html
LayoutTests/webgpu/propertyresolver/indexer-getter-expected.html
LayoutTests/webgpu/propertyresolver/indexer-getter.html
LayoutTests/webgpu/propertyresolver/indexer-setter-abstract-lvalue-3-levels-expected.html
LayoutTests/webgpu/propertyresolver/indexer-setter-abstract-lvalue-3-levels.html
LayoutTests/webgpu/propertyresolver/indexer-setter-abstract-lvalue-expected.html
LayoutTests/webgpu/propertyresolver/indexer-setter-abstract-lvalue.html
LayoutTests/webgpu/propertyresolver/indexer-setter-expected.html
LayoutTests/webgpu/propertyresolver/indexer-setter-lvalue-expected.html
LayoutTests/webgpu/propertyresolver/indexer-setter-lvalue.html
LayoutTests/webgpu/propertyresolver/indexer-setter.html
LayoutTests/webgpu/propertyresolver/setter-abstract-lvalue-3-levels-expected.html
LayoutTests/webgpu/propertyresolver/setter-abstract-lvalue-3-levels.html
LayoutTests/webgpu/propertyresolver/setter-abstract-lvalue-expected.html
LayoutTests/webgpu/propertyresolver/setter-abstract-lvalue.html
LayoutTests/webgpu/propertyresolver/setter-lvalue-expected.html
LayoutTests/webgpu/propertyresolver/setter-lvalue.html
LayoutTests/webgpu/queue-creation.html
LayoutTests/webgpu/render-command-encoding.html
LayoutTests/webgpu/render-pipelines.html
LayoutTests/webgpu/shader-modules.html
LayoutTests/webgpu/simple-triangle-strip-expected.html
LayoutTests/webgpu/simple-triangle-strip.html
LayoutTests/webgpu/texture-triangle-strip-expected.html
LayoutTests/webgpu/texture-triangle-strip.html
LayoutTests/webgpu/textures-textureviews.html
LayoutTests/webgpu/vertex-buffer-triangle-strip-expected.html
LayoutTests/webgpu/vertex-buffer-triangle-strip.html
LayoutTests/webgpu/viewport-scissor-rect-triangle-strip-expected.html
LayoutTests/webgpu/viewport-scissor-rect-triangle-strip.html
LayoutTests/webgpu/webgpu-enabled-expected.txt [deleted file]
LayoutTests/webgpu/webgpu-enabled-in-worker-expected.txt [deleted file]
LayoutTests/webgpu/webgpu-enabled-in-worker.html [deleted file]
LayoutTests/webgpu/webgpu-enabled.html [deleted file]
LayoutTests/webgpu/whlsl-arbitrary-vertex-attribute-locations-expected.html
LayoutTests/webgpu/whlsl-arbitrary-vertex-attribute-locations.html
LayoutTests/webgpu/whlsl-buffer-fragment-expected.html
LayoutTests/webgpu/whlsl-buffer-fragment.html
LayoutTests/webgpu/whlsl-buffer-length-expected.txt
LayoutTests/webgpu/whlsl-buffer-length.html
LayoutTests/webgpu/whlsl-buffer-vertex-expected.html
LayoutTests/webgpu/whlsl-buffer-vertex.html
LayoutTests/webgpu/whlsl-checker-should-set-type-of-read-modify-write-variables-expected.txt
LayoutTests/webgpu/whlsl-checker-should-set-type-of-read-modify-write-variables.html
LayoutTests/webgpu/whlsl-compute-expected.txt
LayoutTests/webgpu/whlsl-compute.html
LayoutTests/webgpu/whlsl-dereference-pointer-should-type-check-expected.html
LayoutTests/webgpu/whlsl-dereference-pointer-should-type-check.html
LayoutTests/webgpu/whlsl-do-while-loop-break-expected.html
LayoutTests/webgpu/whlsl-do-while-loop-break.html
LayoutTests/webgpu/whlsl-do-while-loop-continue-expected.html
LayoutTests/webgpu/whlsl-do-while-loop-continue.html
LayoutTests/webgpu/whlsl-do-while-loop-expected.html
LayoutTests/webgpu/whlsl-do-while-loop.html
LayoutTests/webgpu/whlsl-dont-crash-parsing-enum-expected.html
LayoutTests/webgpu/whlsl-dont-crash-parsing-enum.html
LayoutTests/webgpu/whlsl-dot-expressions-expected.html
LayoutTests/webgpu/whlsl-dot-expressions.html
LayoutTests/webgpu/whlsl-duplicate-types-should-not-produce-duplicate-ctors-expected.txt
LayoutTests/webgpu/whlsl-duplicate-types-should-not-produce-duplicate-ctors.html
LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime-2-expected.html
LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime-2.html
LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime-3-expected.html
LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime-3.html
LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime-expected.html
LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime.html
LayoutTests/webgpu/whlsl-expected.html
LayoutTests/webgpu/whlsl-loops-break-expected.html
LayoutTests/webgpu/whlsl-loops-break.html
LayoutTests/webgpu/whlsl-loops-continue-expected.html
LayoutTests/webgpu/whlsl-loops-continue.html
LayoutTests/webgpu/whlsl-loops-expected.html
LayoutTests/webgpu/whlsl-loops.html
LayoutTests/webgpu/whlsl-matrix-2-expected.txt
LayoutTests/webgpu/whlsl-matrix-2.html
LayoutTests/webgpu/whlsl-matrix-expected.txt
LayoutTests/webgpu/whlsl-matrix.html
LayoutTests/webgpu/whlsl-nested-dot-expression-rvalue-expected.html
LayoutTests/webgpu/whlsl-nested-dot-expression-rvalue.html
LayoutTests/webgpu/whlsl-nested-loop-expected.html
LayoutTests/webgpu/whlsl-nested-loop.html
LayoutTests/webgpu/whlsl-null-dereference-expected.txt
LayoutTests/webgpu/whlsl-null-dereference.html
LayoutTests/webgpu/whlsl-oob-access-expected.txt
LayoutTests/webgpu/whlsl-oob-access.html
LayoutTests/webgpu/whlsl-read-modify-write-expected.txt
LayoutTests/webgpu/whlsl-read-modify-write-high-zombies-expected.txt
LayoutTests/webgpu/whlsl-read-modify-write-high-zombies.html
LayoutTests/webgpu/whlsl-read-modify-write.html
LayoutTests/webgpu/whlsl-return-local-variable-expected.html
LayoutTests/webgpu/whlsl-return-local-variable.html
LayoutTests/webgpu/whlsl-store-to-property-updates-properly-expected.html
LayoutTests/webgpu/whlsl-store-to-property-updates-properly.html
LayoutTests/webgpu/whlsl-textures-getdimensions-expected.txt
LayoutTests/webgpu/whlsl-textures-getdimensions.html
LayoutTests/webgpu/whlsl-textures-load-expected.html
LayoutTests/webgpu/whlsl-textures-load.html
LayoutTests/webgpu/whlsl-textures-sample-expected.html
LayoutTests/webgpu/whlsl-textures-sample.html
LayoutTests/webgpu/whlsl-use-undefined-variable-2-expected.txt
LayoutTests/webgpu/whlsl-use-undefined-variable-2.html
LayoutTests/webgpu/whlsl-use-undefined-variable-expected.txt
LayoutTests/webgpu/whlsl-use-undefined-variable.html
LayoutTests/webgpu/whlsl-while-loop-break-expected.html
LayoutTests/webgpu/whlsl-while-loop-break.html
LayoutTests/webgpu/whlsl-while-loop-continue-expected.html
LayoutTests/webgpu/whlsl-while-loop-continue.html
LayoutTests/webgpu/whlsl-zero-initialize-values-2-expected.html
LayoutTests/webgpu/whlsl-zero-initialize-values-2.html
LayoutTests/webgpu/whlsl-zero-initialize-values-expected.html
LayoutTests/webgpu/whlsl-zero-initialize-values.html
LayoutTests/webgpu/whlsl.html
Source/WTF/ChangeLog
Source/WTF/wtf/Platform.h
Source/WebCore/ChangeLog
Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
Source/WebCore/PAL/pal/spi/cocoa/MetalSPI.h [new file with mode: 0644]
Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm