AX: A few control types are returning the wrong answer for isReadOnly
authordmazzoni@google.com <dmazzoni@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 19 Sep 2012 19:55:19 +0000 (19:55 +0000)
committerdmazzoni@google.com <dmazzoni@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 19 Sep 2012 19:55:19 +0000 (19:55 +0000)
commitd9ed6a03fac2cee61e2f85d6232bacf1e3febbdc
tree4573459c2b1bbf93b9f6987c669d3827460ece9b
parent41758e5270f73320d3e263d553ffe77984a96e34
AX: A few control types are returning the wrong answer for isReadOnly
https://bugs.webkit.org/show_bug.cgi?id=96735

Reviewed by Chris Fleizach.

Source/WebCore:

All input types should be read-only except ones that
are text fields. The previous logic was marking things like
checkboxes as not read-only.

Tests: platform/chromium/accessibility/readonly.html
       platform/mac/accessibility/form-control-value-settable.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isReadOnly):

Tools:

Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.

* DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isReadOnlyGetterCallback):
* DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
(AccessibilityUIElement):

LayoutTests:

Adds a new test to make sure that readonly is exposed correctly on
all elements.

* platform/chromium/accessibility/readonly-expected.txt: Added.
* platform/chromium/accessibility/readonly.html: Added.
* platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
* platform/mac/accessibility/form-control-value-settable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/platform/chromium/accessibility/readonly-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium/accessibility/readonly.html [new file with mode: 0644]
LayoutTests/platform/mac/accessibility/form-control-value-settable-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/accessibility/form-control-value-settable.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/accessibility/AccessibilityNodeObject.cpp
Tools/ChangeLog
Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp
Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h