2011-04-25 Geoffrey Garen <ggaren@apple.com>
authorggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Apr 2011 18:56:02 +0000 (18:56 +0000)
committerggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Apr 2011 18:56:02 +0000 (18:56 +0000)
commitd98614cb8bf263d6e92f859a88a40d4cfb9d77cc
treea30f3ab373fe7b463a1d4b85a716a9a039843bf5
parent3ef6a1ac3c8056a5bef08dcd17117cdf55be36b0
2011-04-25  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
        https://bugs.webkit.org/show_bug.cgi?id=59333

        * WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.

        * bindings/js/JSDOMBinding.cpp:
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDocumentCustom.cpp:
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.

        * bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject
        lifetime management.

        * dom/Document.idl: No need for a custom mark function anymore, since
        ActiveDOMObjets now manage their own lifetimes.

        * dom/MessagePort.cpp:
        (WebCore::MessagePort::hasPendingActivity): Correctly report that we
        have pending activity when we're remotely entangled, instead of relying
        on our clients to know this about us and do the check for us.

        * dom/MessagePort.h: FIXME!

        * dom/MessagePort.idl:
        * fileapi/DOMFileSystem.idl:
        * fileapi/FileReader.idl:
        * fileapi/FileWriter.idl:
        * notifications/Notification.idl:
        * notifications/NotificationCenter.idl:
        * page/EventSource.idl:
        * storage/IDBDatabase.idl:
        * storage/IDBRequest.idl:
        * storage/IDBTransaction.idl:
        * webaudio/AudioContext.idl:
        * websockets/WebSocket.idl:
        * workers/AbstractWorker.idl:
        * workers/SharedWorker.idl:
        * workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.

        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::hasPendingActivity): No need to make up for
        MessagePort::hasPendingActivity being wrong anymore, since it's now right.

        * xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
27 files changed:
Source/WebCore/ChangeLog
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/bindings/js/JSDOMBinding.cpp
Source/WebCore/bindings/js/JSDOMBinding.h
Source/WebCore/bindings/js/JSDocumentCustom.cpp
Source/WebCore/bindings/js/JSWorkerContextCustom.cpp
Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Source/WebCore/dom/Document.idl
Source/WebCore/dom/MessagePort.cpp
Source/WebCore/dom/MessagePort.h
Source/WebCore/dom/MessagePort.idl
Source/WebCore/fileapi/DOMFileSystem.idl
Source/WebCore/fileapi/FileReader.idl
Source/WebCore/fileapi/FileWriter.idl
Source/WebCore/notifications/Notification.idl
Source/WebCore/notifications/NotificationCenter.idl
Source/WebCore/page/EventSource.idl
Source/WebCore/storage/IDBDatabase.idl
Source/WebCore/storage/IDBRequest.idl
Source/WebCore/storage/IDBTransaction.idl
Source/WebCore/webaudio/AudioContext.idl
Source/WebCore/websockets/WebSocket.idl
Source/WebCore/workers/AbstractWorker.idl
Source/WebCore/workers/SharedWorker.idl
Source/WebCore/workers/Worker.idl
Source/WebCore/workers/WorkerContext.cpp
Source/WebCore/xml/XMLHttpRequest.idl