Web Inspector: Test Runtime.saveResult and $n values
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 5 Sep 2015 02:34:22 +0000 (02:34 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 5 Sep 2015 02:34:22 +0000 (02:34 +0000)
commitd8836427a6c6b208165780caea345bb1f45967fa
tree5791e26abef9836f325d13abdb2f46bcf8e10146
parent0a09734019fe9e2cb7ca3689e3f2c78df8b54ec1
Web Inspector: Test Runtime.saveResult and $n values
https://bugs.webkit.org/show_bug.cgi?id=148837

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-09-04
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

* inspector/InjectedScriptSource.js:
(InjectedScript.prototype._evaluateOn):
We don't need to be in the console object group to put the value
in the saved results list. That strong reference will ensure $n
values are always alive even if other object groups were used
when creating and subsequently released.

Source/WebInspectorUI:

* UserInterface/Protocol/InspectorBackend.js:
(InspectorBackendClass):
Initialize the dump logging function different if we are in tests or not.
When in tests, using console.log as well as dumping system activity to
the system console results in an infinite loop of logging!

(InspectorBackendClass.prototype.dispatch):
(InspectorBackendClass.prototype._sendCommandToBackendWithCallback):
Use the logging function we figured out earlier.

LayoutTests:

* inspector/runtime/parse.html: Remove unncessary debug flag.
* inspector/runtime/saveResult-expected.txt: Added.
* inspector/runtime/saveResult.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/inspector/runtime/parse.html
LayoutTests/inspector/runtime/saveResult-expected.txt [new file with mode: 0644]
LayoutTests/inspector/runtime/saveResult.html [new file with mode: 0644]
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/inspector/InjectedScriptSource.js
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js