Remove WebRTC legacy API implementation
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 29 Aug 2018 22:42:26 +0000 (22:42 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 29 Aug 2018 22:42:26 +0000 (22:42 +0000)
commitd5da60d3b7841ff4edca8cce19b403b6305e9b49
tree8b6600ee1ef90ceb22251192b50d535ca22dc008
parent9321aa4f6da6106a8026b86516c57bb48f2ca129
Remove WebRTC legacy API implementation
https://bugs.webkit.org/show_bug.cgi?id=189040

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

* web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt:
* web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt:
* web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https-expected.txt:
* web-platform-tests/webrtc/historical-expected.txt:
* web-platform-tests/webrtc/no-media-call.html:
* web-platform-tests/webrtc/simplecall.https.html:

Source/WebCore:

This API is no longer needed as the runtime flag is off by default.
Removing this option allows removing some code and will ease future WebRTC improvements.
Covered by existing tests.

* CMakeLists.txt:
* DerivedSources.make:
* Modules/mediastream/MediaStreamEvent.cpp: Removed.
* Modules/mediastream/MediaStreamEvent.h: Removed.
* Modules/mediastream/MediaStreamEvent.idl: Removed.
* Modules/mediastream/NavigatorUserMedia.idl: Removed.
* Modules/mediastream/NavigatorUserMedia.js: Removed.
* Modules/mediastream/PeerConnectionBackend.cpp:
* Modules/mediastream/PeerConnectionBackend.h:
* Modules/mediastream/RTCPeerConnection.h:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/RTCPeerConnection.js:
(initializeRTCPeerConnection):
(createOffer):
(createAnswer):
(setLocalDescription):
(setRemoteDescription):
(addIceCandidate):
(getLocalStreams): Deleted.
(getStreamById): Deleted.
(addStream): Deleted.
(): Deleted.
* Modules/mediastream/RTCPeerConnectionInternals.js:
(callbacksAndDictionaryOverload):
(if): Deleted.
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::mediaStreamFromRTCStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteStream):
(WebCore::LibWebRTCMediaEndpoint::removeRemoteStream):
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::LibWebRTCPeerConnectionBackend::doStop):
(WebCore::LibWebRTCPeerConnectionBackend::removeRemoteStream): Deleted.
(WebCore::LibWebRTCPeerConnectionBackend::addRemoteStream): Deleted.
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):
(WebCore::isWebRTCLegacyAPIEnabled): Deleted.
* bindings/js/WebCoreBuiltinNames.h:
* dom/EventNames.in:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webRTCLegacyAPIEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebRTCLegacyAPIEnabled): Deleted.

Source/WebKit:

* Shared/WebPreferences.yaml:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWebRTCLegacyAPIEnabled): Deleted.
(WKPreferencesGetWebRTCLegacyAPIEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRef.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _webRTCLegacyAPIEnabled]): Deleted.
(-[WKPreferences _setWebRTCLegacyAPIEnabled:]): Deleted.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Source/WebKitLegacy/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
(-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setWebRTCLegacyAPIEnabled): Deleted.
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

* TestExpectations:
* fast/events/constructors/media-stream-event-constructor-expected.txt: Removed.
* fast/events/constructors/media-stream-event-constructor.html: Removed.
* fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt: Removed.
* fast/mediastream/RTCPeerConnection-AddRemoveStream.html: Removed.
* fast/mediastream/RTCPeerConnection-createAnswer-expected.txt:
* fast/mediastream/RTCPeerConnection-createAnswer.html:
* fast/mediastream/RTCPeerConnection-createOffer-expected.txt: Removed.
* fast/mediastream/RTCPeerConnection-createOffer.html: Removed.
* fast/mediastream/RTCPeerConnection-dtmf.html: Removed.
* fast/mediastream/RTCPeerConnection-events-expected.txt: Removed.
* fast/mediastream/RTCPeerConnection-events.html: Removed.
* fast/mediastream/RTCPeerConnection-have-local-offer-expected.txt:
* fast/mediastream/RTCPeerConnection-have-local-offer.html:
* fast/mediastream/RTCPeerConnection-have-local-pranswer-expected.txt:
* fast/mediastream/RTCPeerConnection-have-local-pranswer.html:
* fast/mediastream/RTCPeerConnection-have-remote-offer-expected.txt:
* fast/mediastream/RTCPeerConnection-have-remote-offer.html:
* fast/mediastream/RTCPeerConnection-have-remote-pranswer-expected.txt:
* fast/mediastream/RTCPeerConnection-have-remote-pranswer.html:
* fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt: Removed.
* fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html: Removed.
* fast/mediastream/RTCPeerConnection-localDescription-expected.txt:
* fast/mediastream/RTCPeerConnection-localDescription.html:
* fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt:
* fast/mediastream/RTCPeerConnection-remoteDescription.html:
* fast/mediastream/RTCPeerConnection-stable-expected.txt:
* fast/mediastream/RTCPeerConnection-stable.html:
* fast/mediastream/RTCPeerConnection-stats.html:
* fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
* fast/mediastream/RTCPeerConnection-statsSelector.html:
* fast/mediastream/argument-types-expected.txt: Removed.
* fast/mediastream/argument-types.html: Removed.
* fast/mediastream/getusermedia-expected.txt: Removed.
* fast/mediastream/getusermedia.html: Removed.
* fast/mediastream/webkitGetUserMedia-shadowing-then-expected.txt: Removed.
* fast/mediastream/webkitGetUserMedia-shadowing-then.html: Removed.
* platform/mac/TestExpectations:
* webrtc/legacy-api-expected.txt:
* webrtc/legacy-api.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
97 files changed:
LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/fast/events/constructors/media-stream-event-constructor-expected.txt [deleted file]
LayoutTests/fast/events/constructors/media-stream-event-constructor.html [deleted file]
LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt [deleted file]
LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream.html [deleted file]
LayoutTests/fast/mediastream/RTCPeerConnection-createAnswer-expected.txt
LayoutTests/fast/mediastream/RTCPeerConnection-createAnswer.html
LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt [deleted file]
LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html [deleted file]
LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html [deleted file]
LayoutTests/fast/mediastream/RTCPeerConnection-events-expected.txt [deleted file]
LayoutTests/fast/mediastream/RTCPeerConnection-events.html [deleted file]
LayoutTests/fast/mediastream/RTCPeerConnection-have-local-offer-expected.txt
LayoutTests/fast/mediastream/RTCPeerConnection-have-local-offer.html
LayoutTests/fast/mediastream/RTCPeerConnection-have-local-pranswer-expected.txt
LayoutTests/fast/mediastream/RTCPeerConnection-have-local-pranswer.html
LayoutTests/fast/mediastream/RTCPeerConnection-have-remote-offer-expected.txt
LayoutTests/fast/mediastream/RTCPeerConnection-have-remote-offer.html
LayoutTests/fast/mediastream/RTCPeerConnection-have-remote-pranswer-expected.txt
LayoutTests/fast/mediastream/RTCPeerConnection-have-remote-pranswer.html
LayoutTests/fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt [deleted file]
LayoutTests/fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html [deleted file]
LayoutTests/fast/mediastream/RTCPeerConnection-localDescription-expected.txt
LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html
LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt
LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html
LayoutTests/fast/mediastream/RTCPeerConnection-stable-expected.txt
LayoutTests/fast/mediastream/RTCPeerConnection-stable.html
LayoutTests/fast/mediastream/RTCPeerConnection-stats.html
LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector-expected.txt
LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html
LayoutTests/fast/mediastream/argument-types-expected.txt [deleted file]
LayoutTests/fast/mediastream/argument-types.html [deleted file]
LayoutTests/fast/mediastream/getusermedia-expected.txt [deleted file]
LayoutTests/fast/mediastream/getusermedia.html [deleted file]
LayoutTests/fast/mediastream/webkitGetUserMedia-shadowing-then-expected.txt [deleted file]
LayoutTests/fast/mediastream/webkitGetUserMedia-shadowing-then.html [deleted file]
LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt
LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt
LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https-expected.txt
LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https.html
LayoutTests/imported/w3c/web-platform-tests/webrtc/historical-expected.txt
LayoutTests/imported/w3c/web-platform-tests/webrtc/no-media-call.html
LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/setRemoteDescription-expected.txt [deleted file]
LayoutTests/imported/w3c/web-platform-tests/webrtc/simplecall.https.html
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/ios-wk1/TestExpectations
LayoutTests/platform/ios/TestExpectations
LayoutTests/platform/mac-wk1/TestExpectations
LayoutTests/platform/mac/TestExpectations
LayoutTests/platform/win/TestExpectations
LayoutTests/webrtc/legacy-api-expected.txt
LayoutTests/webrtc/legacy-api.html
Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog
Source/WebCore/DerivedSources.make
Source/WebCore/Modules/mediastream/MediaStreamEvent.cpp [deleted file]
Source/WebCore/Modules/mediastream/MediaStreamEvent.h [deleted file]
Source/WebCore/Modules/mediastream/MediaStreamEvent.idl [deleted file]
Source/WebCore/Modules/mediastream/NavigatorUserMedia.idl [deleted file]
Source/WebCore/Modules/mediastream/NavigatorUserMedia.js [deleted file]
Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
Source/WebCore/Modules/mediastream/RTCPeerConnection.h
Source/WebCore/Modules/mediastream/RTCPeerConnection.idl
Source/WebCore/Modules/mediastream/RTCPeerConnection.js
Source/WebCore/Modules/mediastream/RTCPeerConnectionInternals.js
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h
Source/WebCore/Sources.txt
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/bindings/js/JSDOMGlobalObject.cpp
Source/WebCore/bindings/js/WebCoreBuiltinNames.h
Source/WebCore/dom/EventNames.in
Source/WebCore/page/RuntimeEnabledFeatures.h
Source/WebKit/ChangeLog
Source/WebKit/Shared/WebPreferences.yaml
Source/WebKit/UIProcess/API/C/WKPreferences.cpp
Source/WebKit/UIProcess/API/C/WKPreferencesRef.h
Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
Source/WebKitLegacy/mac/WebView/WebPreferences.mm
Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
Source/WebKitLegacy/mac/WebView/WebView.mm
Tools/ChangeLog
Tools/DumpRenderTree/mac/DumpRenderTree.mm
Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
Tools/WebKitTestRunner/TestController.cpp