Uncaught Exception: null is not an object (evaluating 'Object.keys(propertyNames...
authorjoepeck@webkit.org <joepeck@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 13 Sep 2019 18:58:30 +0000 (18:58 +0000)
committerjoepeck@webkit.org <joepeck@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 13 Sep 2019 18:58:30 +0000 (18:58 +0000)
commitd31cefb3b6e963bae92122dcc858ac698135c718
tree3e8acc8118535a4e2230bb597325f5f3d520e150
parentbfdbe6265b02c99475c70d1f9f5ee05a469075a8
Uncaught Exception: null is not an object (evaluating 'Object.keys(propertyNames)​')​ (at JavaScriptRuntimeCompletionProvider.js:​244:​57)​
https://bugs.webkit.org/show_bug.cgi?id=201729

Reviewed by Devin Rousso.

* UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
(WI.JavaScriptRuntimeCompletionProvider):
(WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded):
Don't clear the completion object group until all ongoing requests have completed.
Percision for the lifetime of the object group objects is not important, but we
surely don't want to delete an object too soon.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js