Regression (198943): <marquee> shouldn't wrap text
authorantti@apple.com <antti@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 17 May 2017 15:12:48 +0000 (15:12 +0000)
committerantti@apple.com <antti@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 17 May 2017 15:12:48 +0000 (15:12 +0000)
commitd2c103456e12caed973409996cf46aad72047606
tree8a38ae270e8daf535c1e230ae82122fe47da1451
parent0b0dedaea83ca536ac1901587a6cc666c96712cc
Regression (198943): <marquee> shouldn't wrap text
https://bugs.webkit.org/show_bug.cgi?id=172217

Reviewed by Andreas Kling.

Source/WebCore:

RenderMarquee::updateMarqueeStyle mutated the style and then expected it to inherit to children.
This doesn't work anymore because render tree construction is now separated from style resolution
where inheritance happens.

Test: fast/html/marquee-child-wrap.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):

    Implement marquee hacks in adjustRenderStyle instead. This can't do the childrenInline check
    the previous code had but it wasn't working anyway (there are no children when updateMarqueeStyle
    gets called).

* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::updateMarqueeStyle):

    This no longer needs mutable style.

LayoutTests:

* fast/html/marquee-child-wrap-expected.html: Added.
* fast/html/marquee-child-wrap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/html/marquee-child-wrap-expected.html [new file with mode: 0644]
LayoutTests/fast/html/marquee-child-wrap.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/css/StyleResolver.cpp
Source/WebCore/rendering/RenderMarquee.cpp