Remove the SVG instance tree
authordarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 9 Feb 2015 01:13:35 +0000 (01:13 +0000)
committerdarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 9 Feb 2015 01:13:35 +0000 (01:13 +0000)
commitd2093cfbe4a57170864d10e558c50c9439230eef
tree2419a5646fbf4533acf1e7a0ea533d4ddcbfb4ae
parentab6c3455d0cecd644f92fd145719fb1516fd86ca
Remove the SVG instance tree
https://bugs.webkit.org/show_bug.cgi?id=140602

Reviewed by Dean Jackson.

Source/WebCore:

* CMakeLists.txt: Removed SVGElementInstance source files.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Ditto.
* WebCore.vcxproj/WebCore.vcxproj: Ditto.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Ditto.

* bindings/js/JSEventListener.cpp:
(WebCore::forwardsEventListeners): Deleted. Only returned true for JSSVGElementInstance.
(WebCore::correspondingElementWrapper): Deleted. Only used for JSSVGElementInstance.
(WebCore::createJSEventListenerForAttribute): Deleted. Argument type was JSSVGElementInstance.
(WebCore::createJSEventListenerForAdd): Removed most of the code; later we can delete this entirely.

* bindings/js/JSEventListener.h: Removed the overload of createJSEventListenerForAttribute
that takes a JSSVGElementInstance.

* bindings/js/JSSVGElementInstanceCustom.cpp: Removed.

* dom/ContainerNodeAlgorithms.h: Updated comment to reflect the fact that
this code is really now only used for ContainerNode and no longer needs to
exist in a generic form.

* dom/EventTarget.h: Removed forward declaration of SVGElementInstance.
* svg/SVGElement.h: Ditto.

* dom/EventTargetFactory.in: Removed SVGElementInstance.

* svg/SVGElementInstance.cpp: Removed.
* svg/SVGElementInstance.h: Removed.
* svg/SVGElementInstance.idl: Removed.

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedInto): Removed obsolete comment.
(WebCore::SVGUseElement::instanceTreeIsLoading): Deleted. Unused
function that I forgot to delete in my last patch. It also had a
glaring mistake, a missing "return" before the recursive call to
itself that would cause it to return false when it should return true.

* svg/SVGUseElement.h: Removed instanceTreeIsLoading.

* dom/EventDispatcher.cpp: Removed include of SVGElementInstance.h.
* page/EventHandler.cpp: Ditto.
* rendering/svg/RenderSVGViewportContainer.cpp: Ditto.
* svg/SVGAElement.cpp: Ditto.
* svg/SVGAllInOne.cpp: Ditto.
* svg/SVGAnimateMotionElement.cpp: Ditto.
* svg/SVGAnimatedTypeAnimator.h: Ditto.
* svg/SVGAnimationElement.cpp: Ditto.
* svg/SVGCircleElement.cpp: Ditto.
* svg/SVGClipPathElement.cpp: Ditto.
* svg/SVGComponentTransferFunctionElement.cpp: Ditto.
* svg/SVGCursorElement.cpp: Ditto.
* svg/SVGElement.cpp: Ditto.
* svg/SVGEllipseElement.cpp: Ditto.
* svg/SVGFEBlendElement.cpp: Ditto.
* svg/SVGFEColorMatrixElement.cpp: Ditto.
* svg/SVGFECompositeElement.cpp: Ditto.
* svg/SVGFEConvolveMatrixElement.cpp: Ditto.
* svg/SVGFEDiffuseLightingElement.cpp: Ditto.
* svg/SVGFEDisplacementMapElement.cpp: Ditto.
* svg/SVGFEDropShadowElement.cpp: Ditto.
* svg/SVGFEGaussianBlurElement.cpp: Ditto.
* svg/SVGFEImageElement.cpp: Ditto.
* svg/SVGFELightElement.cpp: Ditto.
* svg/SVGFEMergeNodeElement.cpp: Ditto.
* svg/SVGFEMorphologyElement.cpp: Ditto.
* svg/SVGFEOffsetElement.cpp: Ditto.
* svg/SVGFESpecularLightingElement.cpp: Ditto.
* svg/SVGFETileElement.cpp: Ditto.
* svg/SVGFETurbulenceElement.cpp: Ditto.
* svg/SVGFilterElement.cpp: Ditto.
* svg/SVGFilterPrimitiveStandardAttributes.cpp: Ditto.
* svg/SVGForeignObjectElement.cpp: Ditto.
* svg/SVGGElement.cpp: Ditto.
* svg/SVGGradientElement.cpp: Ditto.
* svg/SVGGraphicsElement.cpp: Ditto.
* svg/SVGImageElement.cpp: Ditto.
* svg/SVGLineElement.cpp: Ditto.
* svg/SVGLinearGradientElement.cpp: Ditto.
* svg/SVGMarkerElement.cpp: Ditto.
* svg/SVGMaskElement.cpp: Ditto.
* svg/SVGPathElement.cpp: Ditto.
* svg/SVGPatternElement.cpp: Ditto.
* svg/SVGPolyElement.cpp: Ditto.
* svg/SVGRadialGradientElement.cpp: Ditto.
* svg/SVGRectElement.cpp: Ditto.
* svg/SVGSVGElement.cpp: Ditto.
* svg/SVGScriptElement.cpp: Ditto.
* svg/SVGStopElement.cpp: Ditto.
* svg/SVGSymbolElement.cpp: Ditto.
* svg/SVGTRefElement.cpp: Ditto.
* svg/SVGTextContentElement.cpp: Ditto.
* svg/SVGTextElement.cpp: Ditto.
* svg/SVGTextPathElement.cpp: Ditto.
* svg/SVGTextPositioningElement.cpp: Ditto.

Tools:

* Scripts/check-for-global-initializers: Removed special case for
SVGElementInstance.o.

LayoutTests:

Last step: Remove SVGElementInstance class itself.

* js/dom/global-constructors-attributes-expected.txt: Removed SVGElementInstance.
* platform/efl/js/dom/global-constructors-attributes-expected.txt: Ditto.
* platform/gtk/js/dom/global-constructors-attributes-expected.txt: Ditto.
* platform/ios-sim-deprecated/fast/dom/Window/window-property-descriptors-expected.txt: Ditto.
* platform/ios-sim-deprecated/fast/js/global-constructors-expected.txt: Ditto.
* platform/ios-sim-deprecated/js/dom/global-constructors-attributes-expected.txt: Ditto.
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt: Ditto.
* platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt: Ditto.
* platform/mac/js/dom/global-constructors-attributes-expected.txt: Ditto.
* platform/win/js/dom/global-constructors-attributes-expected.txt: Ditto.
* svg/custom/global-constructors-expected.txt: Ditto.
* svg/custom/script-tests/global-constructors.js: Ditto.
* svg/dom/svg2-inheritance-expected.txt: Ditto.
* svg/dom/svg2-inheritance.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
92 files changed:
LayoutTests/ChangeLog
LayoutTests/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/ios-sim-deprecated/fast/dom/Window/window-property-descriptors-expected.txt
LayoutTests/platform/ios-sim-deprecated/fast/js/global-constructors-expected.txt
LayoutTests/platform/ios-sim-deprecated/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt
LayoutTests/svg/custom/global-constructors-expected.txt
LayoutTests/svg/custom/script-tests/global-constructors.js
LayoutTests/svg/dom/svg2-inheritance-expected.txt
LayoutTests/svg/dom/svg2-inheritance.html
Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog
Source/WebCore/DerivedSources.cpp
Source/WebCore/DerivedSources.make
Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
Source/WebCore/bindings/js/JSEventListener.cpp
Source/WebCore/bindings/js/JSEventListener.h
Source/WebCore/bindings/js/JSSVGElementInstanceCustom.cpp [deleted file]
Source/WebCore/dom/ContainerNodeAlgorithms.h
Source/WebCore/dom/EventDispatcher.cpp
Source/WebCore/dom/EventTarget.h
Source/WebCore/dom/EventTargetFactory.in
Source/WebCore/page/EventHandler.cpp
Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp
Source/WebCore/svg/SVGAElement.cpp
Source/WebCore/svg/SVGAllInOne.cpp
Source/WebCore/svg/SVGAnimateMotionElement.cpp
Source/WebCore/svg/SVGAnimatedTypeAnimator.h
Source/WebCore/svg/SVGAnimationElement.cpp
Source/WebCore/svg/SVGCircleElement.cpp
Source/WebCore/svg/SVGClipPathElement.cpp
Source/WebCore/svg/SVGComponentTransferFunctionElement.cpp
Source/WebCore/svg/SVGCursorElement.cpp
Source/WebCore/svg/SVGElement.cpp
Source/WebCore/svg/SVGElement.h
Source/WebCore/svg/SVGElementInstance.cpp [deleted file]
Source/WebCore/svg/SVGElementInstance.h [deleted file]
Source/WebCore/svg/SVGElementInstance.idl [deleted file]
Source/WebCore/svg/SVGEllipseElement.cpp
Source/WebCore/svg/SVGFEBlendElement.cpp
Source/WebCore/svg/SVGFEColorMatrixElement.cpp
Source/WebCore/svg/SVGFECompositeElement.cpp
Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp
Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp
Source/WebCore/svg/SVGFEDisplacementMapElement.cpp
Source/WebCore/svg/SVGFEDropShadowElement.cpp
Source/WebCore/svg/SVGFEGaussianBlurElement.cpp
Source/WebCore/svg/SVGFEImageElement.cpp
Source/WebCore/svg/SVGFELightElement.cpp
Source/WebCore/svg/SVGFEMergeNodeElement.cpp
Source/WebCore/svg/SVGFEMorphologyElement.cpp
Source/WebCore/svg/SVGFEOffsetElement.cpp
Source/WebCore/svg/SVGFESpecularLightingElement.cpp
Source/WebCore/svg/SVGFETileElement.cpp
Source/WebCore/svg/SVGFETurbulenceElement.cpp
Source/WebCore/svg/SVGFilterElement.cpp
Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp
Source/WebCore/svg/SVGForeignObjectElement.cpp
Source/WebCore/svg/SVGGElement.cpp
Source/WebCore/svg/SVGGradientElement.cpp
Source/WebCore/svg/SVGGraphicsElement.cpp
Source/WebCore/svg/SVGImageElement.cpp
Source/WebCore/svg/SVGLineElement.cpp
Source/WebCore/svg/SVGLinearGradientElement.cpp
Source/WebCore/svg/SVGMarkerElement.cpp
Source/WebCore/svg/SVGMaskElement.cpp
Source/WebCore/svg/SVGPathElement.cpp
Source/WebCore/svg/SVGPatternElement.cpp
Source/WebCore/svg/SVGPolyElement.cpp
Source/WebCore/svg/SVGRadialGradientElement.cpp
Source/WebCore/svg/SVGRectElement.cpp
Source/WebCore/svg/SVGSVGElement.cpp
Source/WebCore/svg/SVGScriptElement.cpp
Source/WebCore/svg/SVGStopElement.cpp
Source/WebCore/svg/SVGSymbolElement.cpp
Source/WebCore/svg/SVGTRefElement.cpp
Source/WebCore/svg/SVGTextContentElement.cpp
Source/WebCore/svg/SVGTextElement.cpp
Source/WebCore/svg/SVGTextPathElement.cpp
Source/WebCore/svg/SVGTextPositioningElement.cpp
Source/WebCore/svg/SVGUseElement.cpp
Source/WebCore/svg/SVGUseElement.h
Tools/ChangeLog
Tools/Scripts/check-for-global-initializers