2011-01-14 Andrey Kosyakov <caseq@chromium.org>
authorcaseq@chromium.org <caseq@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Jan 2011 12:25:39 +0000 (12:25 +0000)
committercaseq@chromium.org <caseq@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Jan 2011 12:25:39 +0000 (12:25 +0000)
commitd1dec6601ccad020bfbe8ba33284bfb0300480fc
treef1fb73ef1099ed4b41b70eaa757a8b3a98b01ae1
parent2ab0e07ea9ad59307ed0f08aa320655581e54426
2011-01-14  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: redirected resources not handled properly in Network panel
        https://bugs.webkit.org/show_bug.cgi?id=52292

        * inspector/Inspector.idl: Do not pass isMainResource to identifierForInitialRequest() (it's useless, as we may hit provisional load)
        * inspector/InspectorInstrumentation.cpp: Ditto.
        (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
        * inspector/InspectorResourceAgent.cpp: Ditto.
        (WebCore::InspectorResourceAgent::identifierForInitialRequest):
        * inspector/InspectorResourceAgent.h: Ditto.
        * inspector/InspectorInstrumentation.cpp: Ditto.
        (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): Fix main resource detection.
        * inspector/front-end/AuditsPanel.js: WebInspector.networkResources now returns array, not map.
        * inspector/front-end/ConsoleView.js: User WebInspector.resourceById() to get resource
        (WebInspector.ConsoleMessage.prototype._formatMessage):
        * inspector/front-end/ExtensionServer.js: Ditto.
        (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
        (WebInspector.ExtensionServer.prototype._onGetResourceContent):
        * inspector/front-end/HAREntry.js: WebInspector.networkResources now returns array, not map
        (WebInspector.HARLog.prototype.build):
        (WebInspector.HARLog.prototype._convertResource):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager): Use appendResource, not refreshResource, when adding a new resource.
        (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
        (WebInspector.NetworkManager.prototype.willSendRequest):
        (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
        (WebInspector.NetworkManager.prototype.setInitialContent):
        (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
        (WebInspector.NetworkManager.prototype.didCreateWebSocket):
        (WebInspector.NetworkManager.prototype._createResource): always register resource URL with ResourceTreeModel
        (WebInspector.NetworkManager.prototype._appendRedirect):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype.get resources):
        (WebInspector.NetworkPanel.prototype.resourceById):
        (WebInspector.NetworkPanel.prototype.appendResource): Add resource as new iff appendResource was added.
        (WebInspector.NetworkPanel.prototype.refreshResource): ditto.
        (WebInspector.NetworkPanel.prototype.mainResourceChanged): Clear console upon arrival of new main resource.
        * inspector/front-end/ResourceTreeModel.js: Expose unbindResourceURL, bind resources automatically upon creation.
        (WebInspector.ResourceTreeModel.prototype._clearResources):
        (WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
        (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
        (WebInspector.ResourceTreeModel.prototype.createResource):
        * inspector/front-end/inspector.js:
        (WebInspector.resourceById):

2011-01-14  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: redirected resources not handled properly in Network panel
        Added test for redirected resource presence in HAR
        Changed test to request entire HAR log, not multiple HAR entries.
        https://bugs.webkit.org/show_bug.cgi?id=52292

        * http/tests/inspector/extensions-resources-redirect-expected.txt:
        * http/tests/inspector/extensions-resources-redirect.html:
        * http/tests/inspector/resource-har-conversion.html:
        * inspector/extensions-resources.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
18 files changed:
LayoutTests/ChangeLog
LayoutTests/http/tests/inspector/extensions-resources-redirect-expected.txt
LayoutTests/http/tests/inspector/extensions-resources-redirect.html
LayoutTests/http/tests/inspector/resource-har-conversion.html
LayoutTests/inspector/extensions-resources.html
Source/WebCore/ChangeLog
Source/WebCore/inspector/Inspector.idl
Source/WebCore/inspector/InspectorInstrumentation.cpp
Source/WebCore/inspector/InspectorResourceAgent.cpp
Source/WebCore/inspector/InspectorResourceAgent.h
Source/WebCore/inspector/front-end/AuditsPanel.js
Source/WebCore/inspector/front-end/ConsoleView.js
Source/WebCore/inspector/front-end/ExtensionServer.js
Source/WebCore/inspector/front-end/HAREntry.js
Source/WebCore/inspector/front-end/NetworkManager.js
Source/WebCore/inspector/front-end/NetworkPanel.js
Source/WebCore/inspector/front-end/ResourceTreeModel.js
Source/WebCore/inspector/front-end/inspector.js