Make AccessibilityObject::size non-virtual and fix platform accessibility code's...
authorleviw@chromium.org <leviw@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 12 Apr 2012 20:56:47 +0000 (20:56 +0000)
committerleviw@chromium.org <leviw@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 12 Apr 2012 20:56:47 +0000 (20:56 +0000)
commitd1c38aaf68371469f3855e5ebd1886e78359db2d
tree2205c9bad1094502b96e93a842b449964d7adae4
parentaf3dad6484a5d86a3d4b23578c7b4507bb3d9d02
Make AccessibilityObject::size non-virtual and fix platform accessibility code's LayoutUnit usage
https://bugs.webkit.org/show_bug.cgi?id=83803

Reviewed by Eric Seidel.

AccessibilityObject::size was virtual with a number of overloads, but all the implementations were
redundant. Avoiding the virtual thunk and code duplication by declaring it non-virtual and only
implementing it in AccessibilityObject.

Also adding a pixelSnappedSize method that returns an IntSize, and using it in platform
accessibility code.

No new tests. No change in behavior.

* accessibility/AccessibilityMenuListOption.h:
(WebCore::AccessibilityMenuListOption::canHaveChildren):
* accessibility/AccessibilityMenuListPopup.h:
(WebCore::AccessibilityMenuListPopup::elementRect):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::pixelSnappedSize):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilitySlider.cpp:
(WebCore):
* accessibility/AccessibilitySlider.h:
(AccessibilitySliderThumb):
* accessibility/AccessibilityTableColumn.cpp:
(WebCore):
* accessibility/AccessibilityTableColumn.h:
(AccessibilityTableColumn):
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore):
* accessibility/AccessibilityTableHeaderContainer.h:
(AccessibilityTableHeaderContainer):
* accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp:
(webkitAccessibleComponentGetExtents):
* accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:
(webkitAccessibleImageGetImagePosition):
(webkitAccessibleImageGetImageSize):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper position]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
15 files changed:
Source/WebCore/ChangeLog
Source/WebCore/accessibility/AccessibilityMenuListOption.h
Source/WebCore/accessibility/AccessibilityMenuListPopup.h
Source/WebCore/accessibility/AccessibilityObject.h
Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Source/WebCore/accessibility/AccessibilityRenderObject.h
Source/WebCore/accessibility/AccessibilitySlider.cpp
Source/WebCore/accessibility/AccessibilitySlider.h
Source/WebCore/accessibility/AccessibilityTableColumn.cpp
Source/WebCore/accessibility/AccessibilityTableColumn.h
Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp
Source/WebCore/accessibility/AccessibilityTableHeaderContainer.h
Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp
Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceImage.cpp
Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm