Move WKWebViewConfiguration validation to WKWebView construction
authorachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 26 Oct 2017 23:59:59 +0000 (23:59 +0000)
committerachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 26 Oct 2017 23:59:59 +0000 (23:59 +0000)
commitd0de91d2f501ef066261cedaae47ee6e993039ba
treefe29e797b13654432da2a1c170df1220cb79fe15
parent599889fd2dc5443e01312d7307701010d248c690
Move WKWebViewConfiguration validation to WKWebView construction
https://bugs.webkit.org/show_bug.cgi?id=178840

Reviewed by Tim Horton.
Source/WebKit:

I'm trying to remove WKWebViewConfigurationInternal methods so I can make WKWebViewConfiguration
a wrapper around an APIObject like all the other API objects.  A small step towards making this easier
is to remove the unnecessary method _validate and move its logic to its one callsite.  I added an API test
that ensures no change in behavior.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _validate]): Deleted.
* UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h:

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm: Added.
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebKit/ChangeLog
Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h
Tools/ChangeLog
Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm [new file with mode: 0644]