All scrolling height/width values should be integral rounded.
authorzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 14 May 2016 05:14:08 +0000 (05:14 +0000)
committerzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 14 May 2016 05:14:08 +0000 (05:14 +0000)
commitcea73c07bee018d1fdda9acd8cec03cd07de1820
tree68d36d12c8736d1efd6954cbb1cd3946b0e28bdb
parentcdef95329387afb10573fc486467488b5e6907a8
All scrolling height/width values should be integral rounded.
https://bugs.webkit.org/show_bug.cgi?id=157687

Reviewed by Simon Fraser.

Both clientHeight(Width) and scrollHeight(width) need to be explicitly integral
rounded in order to ensure that scrollable content is computed properly.
This will evolve into subpixel snapping once we apply subpixel arithmetics on scrolling.

Source/WebCore:

Not testable.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::horizontalScrollbarStart):
(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
* rendering/RenderLayer.h:

LayoutTests:

* platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
* platform/mac/fast/css/text-overflow-input-expected.txt:
* platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
* platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
* platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
* platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@200915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
17 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/ios-simulator/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt
LayoutTests/platform/ios-simulator/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt
LayoutTests/platform/ios-simulator/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt
LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt
LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt
LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt
LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt
LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt
LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt
LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt
LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt
LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBox.cpp
Source/WebCore/rendering/RenderLayer.cpp
Source/WebCore/rendering/RenderLayer.h