Move non-Settings Inspector methods from internals.settings to internals
authortony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Oct 2012 21:59:55 +0000 (21:59 +0000)
committertony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Oct 2012 21:59:55 +0000 (21:59 +0000)
commitcdbe8f2a75d0374b147092ba38d7b0c422e5bfdc
treee0de96604bba0092167103e751445bf0075f5dfb
parent7942b301c43f2b636808e5426111a157b511f9b3
Move non-Settings Inspector methods from internals.settings to internals
https://bugs.webkit.org/show_bug.cgi?id=100392

Reviewed by Adam Barth.

Source/WebCore:

These methods don't have to do with the WebCore Settings object, so move them up to internals.
I moved the reset code from InternalSettings to Internals.

No new tests, this is just a rename. Existing tests should pass.

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Remove inspector methods.
(WebCore::InternalSettings::Backup::restoreTo): Remove inspector methods.
* testing/InternalSettings.h:
* testing/InternalSettings.idl:
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): New method for resetting page state. Named after similar
methods in WTR.
(WebCore::Internals::setInspectorResourcesDataSizeLimits): Moved from InspectorSettings.
(WebCore::Internals::setJavaScriptProfilingEnabled): Moved from InspectorSettings.
* testing/Internals.h:
* testing/Internals.idl:
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): Reset state in Internals.
* testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): Reset state in Internals.

LayoutTests:

Update tests to use internals.setJavaScriptProfilingEnabled instead of internals.settings.setJavaScriptProfilingEnabled.
Update tests to use internals.setInspectorResourcesDataSizeLimits instead of internals.settings.setInspectorResourcesDataSizeLimits.

* fast/profiler/anonymous-event-handler.html:
* fast/profiler/anonymous-function-called-from-different-contexts.html:
* fast/profiler/anonymous-function-calls-built-in-functions.html:
* fast/profiler/anonymous-function-calls-eval.html:
* fast/profiler/anonymous-functions-with-display-names.html:
* fast/profiler/apply.html:
* fast/profiler/built-in-function-calls-anonymous.html:
* fast/profiler/built-in-function-calls-user-defined-function.html:
* fast/profiler/call-register-leak.html:
* fast/profiler/call.html:
* fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
* fast/profiler/compare-multiple-profiles.html:
* fast/profiler/constructor.html:
* fast/profiler/dead-time.html:
* fast/profiler/document-dot-write.html:
* fast/profiler/event-handler.html:
* fast/profiler/execution-context-and-eval-on-same-line.html:
* fast/profiler/inline-event-handler.html:
* fast/profiler/many-calls-in-the-same-scope.html:
* fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
* fast/profiler/multiple-and-different-scoped-function-calls.html:
* fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html:
* fast/profiler/multiple-frames.html:
* fast/profiler/named-functions-with-display-names.html:
* fast/profiler/nested-anonymous-functon.html:
* fast/profiler/nested-start-and-stop-profiler.html:
* fast/profiler/no-execution-context.html:
* fast/profiler/one-execution-context.html:
* fast/profiler/profile-calls-in-included-file.html:
* fast/profiler/profile-with-no-title.html:
* fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
* fast/profiler/profiling-from-a-nested-location.html:
* fast/profiler/simple-event-call.html:
* fast/profiler/simple-no-level-change.html:
* fast/profiler/start-and-stop-profiler-multiple-times.html:
* fast/profiler/start-and-stop-profiling-in-the-same-function.html:
* fast/profiler/start-but-dont-stop-profiling.html:
* fast/profiler/stop-profiling-after-setTimeout.html:
* fast/profiler/stop-then-function-call.html:
* fast/profiler/two-execution-contexts.html:
* fast/profiler/user-defined-function-calls-built-in-functions.html:
* fast/profiler/window-dot-eval.html:
* http/tests/inspector/network-test.js:
(resetInspectorResourcesData):
* http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html:
* http/tests/inspector/network/network-content-replacement-embed.html:
* http/tests/inspector/network/network-content-replacement-xhr.html:
* inspector/profiler/cpu-profiler-profiling-without-inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
57 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/profiler/anonymous-event-handler.html
LayoutTests/fast/profiler/anonymous-function-called-from-different-contexts.html
LayoutTests/fast/profiler/anonymous-function-calls-built-in-functions.html
LayoutTests/fast/profiler/anonymous-function-calls-eval.html
LayoutTests/fast/profiler/anonymous-functions-with-display-names.html
LayoutTests/fast/profiler/apply.html
LayoutTests/fast/profiler/built-in-function-calls-anonymous.html
LayoutTests/fast/profiler/built-in-function-calls-user-defined-function.html
LayoutTests/fast/profiler/call-register-leak.html
LayoutTests/fast/profiler/call.html
LayoutTests/fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html
LayoutTests/fast/profiler/compare-multiple-profiles.html
LayoutTests/fast/profiler/constructor.html
LayoutTests/fast/profiler/dead-time.html
LayoutTests/fast/profiler/document-dot-write.html
LayoutTests/fast/profiler/event-handler.html
LayoutTests/fast/profiler/execution-context-and-eval-on-same-line.html
LayoutTests/fast/profiler/inline-event-handler.html
LayoutTests/fast/profiler/many-calls-in-the-same-scope.html
LayoutTests/fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html
LayoutTests/fast/profiler/multiple-and-different-scoped-function-calls.html
LayoutTests/fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html
LayoutTests/fast/profiler/multiple-frames.html
LayoutTests/fast/profiler/named-functions-with-display-names.html
LayoutTests/fast/profiler/nested-anonymous-functon.html
LayoutTests/fast/profiler/nested-start-and-stop-profiler.html
LayoutTests/fast/profiler/no-execution-context.html
LayoutTests/fast/profiler/one-execution-context.html
LayoutTests/fast/profiler/profile-calls-in-included-file.html
LayoutTests/fast/profiler/profile-with-no-title.html
LayoutTests/fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html
LayoutTests/fast/profiler/profiling-from-a-nested-location.html
LayoutTests/fast/profiler/simple-event-call.html
LayoutTests/fast/profiler/simple-no-level-change.html
LayoutTests/fast/profiler/start-and-stop-profiler-multiple-times.html
LayoutTests/fast/profiler/start-and-stop-profiling-in-the-same-function.html
LayoutTests/fast/profiler/start-but-dont-stop-profiling.html
LayoutTests/fast/profiler/stop-profiling-after-setTimeout.html
LayoutTests/fast/profiler/stop-then-function-call.html
LayoutTests/fast/profiler/two-execution-contexts.html
LayoutTests/fast/profiler/user-defined-function-calls-built-in-functions.html
LayoutTests/fast/profiler/window-dot-eval.html
LayoutTests/http/tests/inspector/network-test.js
LayoutTests/http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html
LayoutTests/http/tests/inspector/network/network-content-replacement-embed.html
LayoutTests/http/tests/inspector/network/network-content-replacement-xhr.html
LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector.html
Source/WebCore/ChangeLog
Source/WebCore/testing/InternalSettings.cpp
Source/WebCore/testing/InternalSettings.h
Source/WebCore/testing/InternalSettings.idl
Source/WebCore/testing/Internals.cpp
Source/WebCore/testing/Internals.h
Source/WebCore/testing/Internals.idl
Source/WebCore/testing/js/WebCoreTestSupport.cpp
Source/WebCore/testing/v8/WebCoreTestSupport.cpp