Web Inspector: Table selection should not require that rows be in the cache
authormattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Nov 2018 19:01:30 +0000 (19:01 +0000)
committermattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Nov 2018 19:01:30 +0000 (19:01 +0000)
commitcd0c4e92501f0bf45bd18c3168748c0a2b070f0a
tree3b89678e2659beaaad6acbb958ba53f1a7e0f309
parent326030bbe8a3f7889d66395c2df1ec93f6bd4451
Web Inspector: Table selection should not require that rows be in the cache
https://bugs.webkit.org/show_bug.cgi?id=190993
<rdar://problem/45613812>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Deselecting a table row shouldn't depend on it being in the cache. This
allows us to implement select all, and other kinds of bulk selection
actions that affect rows that haven't been revealed.

* UserInterface/Views/Table.js:
(WI.Table.prototype.deselectRow):

LayoutTests:

Add a test that a table row that is not in the cache can be selected/deselected.

* inspector/table/table-selection-expected.txt:
* inspector/table/table-selection.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/inspector/table/table-selection-expected.txt
LayoutTests/inspector/table/table-selection.html
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/Table.js