2010-03-26 Dirk Pranke <dpranke@chromium.org>
authordpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Mar 2010 23:38:37 +0000 (23:38 +0000)
committerdpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Mar 2010 23:38:37 +0000 (23:38 +0000)
commitcc05613aa32a577e920ddb4c549da31b02b9c485
tree3cf35aff2bf0e9424ee0b9c3332141b8a0b516b3
parent6acb56c1382b1b88883cc790996eaa1e32bc9676
2010-03-26  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Implement pixel tests (image diff) properly on the Mac port.

        This change introduces a new "ServerPocess" class that can be used
        to manage processes that the run-webkit-tests harness forks off and
        expects to stay up for longer than a single request/response session.
        Both DumpRenderTree and ImageDiff use this style of communication,
        although the current code forks off a new ImageDiff for each diff
        (We need to restructure other parts of the code to be able to do this
        safely in a multi-threaded environment).

        Also, now that the ServerProcess abstraction exists, we can probably
        clean up and simplify some of the thread management logic in
        test_shell_thread as well.

        https://bugs.webkit.org/show_bug.cgi?id=34826

        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/server_process.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKitTools/ChangeLog
WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py
WebKitTools/Scripts/webkitpy/layout_tests/port/server_process.py [new file with mode: 0644]
WebKitTools/Scripts/webkitpy/layout_tests/test_types/image_diff.py