Remove fullscreen-auto-hide-delay
authordino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Jul 2018 00:25:14 +0000 (00:25 +0000)
committerdino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Jul 2018 00:25:14 +0000 (00:25 +0000)
commitc8d2c418c38358faf5f637780ad02c3510442130
tree6210155b553f4601bb11d1a098fbe64d85ffad83
parentfee4f9d3aac56d10ac514d66e8e4f9cbc40150cb
Remove fullscreen-auto-hide-delay
https://bugs.webkit.org/show_bug.cgi?id=187493
<rdar://problem/41830852>

Reviewed by Antoine Quint.

Source/WebCore:

Remove the env() value for fullscreen-auto-hide-delay.

* dom/ConstantPropertyMap.cpp:
(WebCore::ConstantPropertyMap::nameForProperty const):
(WebCore::ConstantPropertyMap::setFullscreenAutoHideDelay): Deleted.
* dom/ConstantPropertyMap.h:
* page/Page.cpp:
(WebCore::Page::setFullscreenAutoHideDelay): Deleted.
* page/Page.h:
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): No need to reset delay.
(WebCore::Internals::setFullscreenAutoHideDelay): Deleted.
* testing/Internals.h: Remove the delay setter/getter.
* testing/Internals.idl:

Source/WebKit:

Now there is no delay, rename setFullscreenAutoHideTiming to setFullscreenAutoHideDuration,
and only send that value over to the Web Process.

* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::setFullscreenAutoHideDuration):
(WebKit::WebFullScreenManagerProxy::setFullscreenAutoHideTiming): Deleted.
* UIProcess/WebFullScreenManagerProxy.h:
* UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController viewWillAppear:]):
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::didExitFullScreen):
(WebKit::WebFullScreenManager::setFullscreenAutoHideDuration):
(WebKit::WebFullScreenManager::setFullscreenAutoHideTiming): Deleted.
* WebProcess/FullScreen/WebFullScreenManager.h:
* WebProcess/FullScreen/WebFullScreenManager.messages.in:

LayoutTests:

Update the existing test that partially used the delay, and remove the ones that
used only the delay.

* fullscreen/fullscreen-auto-hide-delay-expected.txt: Removed.
* fullscreen/fullscreen-auto-hide-delay.html: Removed.
* fullscreen/fullscreen-env-expected.txt:
* fullscreen/fullscreen-env.html:
* legacy-animation-engine/fullscreen/fullscreen-auto-hide-delay-expected.txt: Removed.
* legacy-animation-engine/fullscreen/fullscreen-auto-hide-delay.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
22 files changed:
LayoutTests/ChangeLog
LayoutTests/fullscreen/fullscreen-auto-hide-delay-expected.txt [deleted file]
LayoutTests/fullscreen/fullscreen-auto-hide-delay.html [deleted file]
LayoutTests/fullscreen/fullscreen-env-expected.txt
LayoutTests/fullscreen/fullscreen-env.html
LayoutTests/legacy-animation-engine/fullscreen/fullscreen-auto-hide-delay-expected.txt [deleted file]
LayoutTests/legacy-animation-engine/fullscreen/fullscreen-auto-hide-delay.html [deleted file]
Source/WebCore/ChangeLog
Source/WebCore/dom/ConstantPropertyMap.cpp
Source/WebCore/dom/ConstantPropertyMap.h
Source/WebCore/page/Page.cpp
Source/WebCore/page/Page.h
Source/WebCore/testing/Internals.cpp
Source/WebCore/testing/Internals.h
Source/WebCore/testing/Internals.idl
Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
Source/WebKit/UIProcess/WebFullScreenManagerProxy.h
Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h
Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.messages.in