Delete button doesn't fully delete certain emoji
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Oct 2017 01:15:42 +0000 (01:15 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Oct 2017 01:15:42 +0000 (01:15 +0000)
commitc70b9f01438b2a4ce8c31821031df48a967e002a
tree80a3e7a590465602e6b3d67665d9dc8802f01504
parent6eada709079ed26fcaee5d896cea8c44f5c2c086
Delete button doesn't fully delete certain emoji
https://bugs.webkit.org/show_bug.cgi?id=178096
<rdar://problem/34785106>

Reviewed by Simon Fraser.

Source/WebCore:

System infrastructure for handling emoji changes every year. Instead of having
custom code to specifically walk over codepoints, we should delegate to the
system handling.

Test: editing/deleting/delete-emoji.html

* rendering/RenderText.cpp:
(WebCore::RenderText::previousOffset const):
(WebCore::RenderText::previousOffsetForBackwardDeletion const):
(WebCore::RenderText::nextOffset const):
(WebCore::isHangulLVT): Deleted.
(WebCore::isMark): Deleted.
(WebCore::isRegionalIndicator): Deleted.
(WebCore::isInArmenianToLimbuRange): Deleted.

LayoutTests:

* editing/deleting/delete-emoji-2.html:
* platform/mac/editing/deleting/delete-emoji-expected.txt:
* platform/mac/editing/deleting/delete-emoji-2-expected.txt:
* platform/ios/editing/deleting/delete-emoji-expected.txt:
* platform/ios/editing/deleting/delete-emoji-2-expected.txt:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/editing/deleting/delete-emoji-2.html [new file with mode: 0644]
LayoutTests/platform/ios/editing/deleting/delete-emoji-2-expected.txt [new file with mode: 0644]
LayoutTests/platform/ios/editing/deleting/delete-emoji-expected.txt
LayoutTests/platform/mac/editing/deleting/delete-emoji-2-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/editing/deleting/delete-emoji-expected.txt
LayoutTests/platform/win/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderText.cpp