https://bugs.webkit.org/show_bug.cgi?id=48569
authorhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 29 Oct 2010 06:30:10 +0000 (06:30 +0000)
committerhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 29 Oct 2010 06:30:10 +0000 (06:30 +0000)
commitc35fb094076a67fe30a6762d5f8aa137a2804012
treee1a82ffa9d73fbe658b9044f04f087ba09f3ce09
parent46f77184fa3328165598f79b78a18788a6927eca
https://bugs.webkit.org/show_bug.cgi?id=48569

Reviewed by Dan Bernstein.

Box shadows on vertical inlines don't paint properly.  Fix the paintBoxShadow method to treat the edges to include as
logical (so that top/bottom are used instead of left/right for vertical lines).  In order to make my box-shadow tests
work I had to fix a bug in the transform code of InlineTextBox that was causing the baselines of vertical lines to
be wrong.

Added fast/blockflow/box-shadow-* tests

WebCore:

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
* rendering/RenderBoxModelObject.h:

LayoutTests:

* fast/blockflow/box-shadow-horizontal-bt.html: Added.
* fast/blockflow/box-shadow-vertical-lr.html: Added.
* fast/blockflow/box-shadow-vertical-rl.html: Added.
* platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
* platform/mac/fast/blockflow/border-vertical-lr-expected.png:
* platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
* platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
* platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
* platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
* platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
* platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
* platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
* platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
* platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
* platform/mac/fast/blockflow/english-lr-text-expected.checksum:
* platform/mac/fast/blockflow/english-lr-text-expected.png:
* platform/mac/fast/blockflow/english-rl-text-expected.checksum:
* platform/mac/fast/blockflow/english-rl-text-expected.png:
* platform/mac/fast/blockflow/japanese-lr-text-expected.checksum:
* platform/mac/fast/blockflow/japanese-lr-text-expected.png:
* platform/mac/fast/blockflow/japanese-rl-text-expected.checksum:
* platform/mac/fast/blockflow/japanese-rl-text-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
29 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/blockflow/box-shadow-horizontal-bt.html [new file with mode: 0644]
LayoutTests/fast/blockflow/box-shadow-vertical-lr.html [new file with mode: 0644]
LayoutTests/fast/blockflow/box-shadow-vertical-rl.html [new file with mode: 0644]
LayoutTests/platform/mac/fast/blockflow/border-vertical-lr-expected.checksum
LayoutTests/platform/mac/fast/blockflow/border-vertical-lr-expected.png
LayoutTests/platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/fast/blockflow/english-lr-text-expected.checksum
LayoutTests/platform/mac/fast/blockflow/english-lr-text-expected.png
LayoutTests/platform/mac/fast/blockflow/english-rl-text-expected.checksum
LayoutTests/platform/mac/fast/blockflow/english-rl-text-expected.png
LayoutTests/platform/mac/fast/blockflow/japanese-lr-text-expected.checksum
LayoutTests/platform/mac/fast/blockflow/japanese-lr-text-expected.png
LayoutTests/platform/mac/fast/blockflow/japanese-rl-text-expected.checksum
LayoutTests/platform/mac/fast/blockflow/japanese-rl-text-expected.png
LayoutTests/platform/mac/fast/text/international/vertical-text-glyph-test-expected.checksum
LayoutTests/platform/mac/fast/text/international/vertical-text-glyph-test-expected.png
WebCore/ChangeLog
WebCore/rendering/InlineTextBox.cpp
WebCore/rendering/RenderBoxModelObject.cpp
WebCore/rendering/RenderBoxModelObject.h