Kill FontFamilyValue.
authorkling@webkit.org <kling@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 21 Feb 2012 18:00:00 +0000 (18:00 +0000)
committerkling@webkit.org <kling@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 21 Feb 2012 18:00:00 +0000 (18:00 +0000)
commitc0c2270c26bd7865a8e91e995e8e61ae3618e712
tree07cfa973a95b680c7b1c90c6c2288c586b7675d1
parent620466d4a8c3533849bac774a6fad6f4bbdae70b
Kill FontFamilyValue.
<http://webkit.org/b/79103>

Reviewed by Antti Koivisto.

Source/WebCore:

Remove FontFamilyValue and replace all usage by CSSPrimitiveValue.
The class was only used to filter font family names, removing bracketed
suffixes, e.g "[Xft]".

This was added to KHTML in 2002 to support the use of specific X11 font
families inside KMail: <https://bugs.kde.org/show_bug.cgi?id=38808>

Test: fast/css/font-family-trailing-bracket-gunk.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSParser.cpp:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSValue.cpp:
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
* css/CSSValuePool.h:
(CSSValuePool):
* css/FontFamilyValue.cpp: Removed.
* css/FontFamilyValue.h: Removed.

LayoutTests:

* fast/css/font-family-trailing-bracket-gunk-expected.txt: Added.
* fast/css/font-family-trailing-bracket-gunk.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
20 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/css/font-family-trailing-bracket-gunk-expected.txt [new file with mode: 0644]
LayoutTests/fast/css/font-family-trailing-bracket-gunk.html [new file with mode: 0644]
Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog
Source/WebCore/GNUmakefile.list.am
Source/WebCore/Target.pri
Source/WebCore/WebCore.gypi
Source/WebCore/WebCore.order
Source/WebCore/WebCore.vcproj/WebCore.vcproj
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/css/CSSFontSelector.cpp
Source/WebCore/css/CSSParser.cpp
Source/WebCore/css/CSSStyleSelector.cpp
Source/WebCore/css/CSSValue.cpp
Source/WebCore/css/CSSValue.h
Source/WebCore/css/CSSValuePool.cpp
Source/WebCore/css/CSSValuePool.h
Source/WebCore/css/FontFamilyValue.cpp [deleted file]
Source/WebCore/css/FontFamilyValue.h [deleted file]