2010-06-07 Martin Robinson <mrobinson@igalia.com>
authormrobinson@webkit.org <mrobinson@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 7 Jun 2010 22:45:58 +0000 (22:45 +0000)
committermrobinson@webkit.org <mrobinson@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 7 Jun 2010 22:45:58 +0000 (22:45 +0000)
commitbf8327dc2f1d20787216cc7e472bb78c8ba1a951
tree31d44ecbb3d21dbf4775c622496b0b1fe1d210ea
parent41352efce85e087d6038f3d38b2f6de87213d9fe
2010-06-07  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Oliver Hunt.

        [GTK] HTML5 input type=range is not drawn
        https://bugs.webkit.org/show_bug.cgi?id=39561

        Uncomment and add baselines for slider tests which are now passing. Group
        remaining failing slider tests by their type of failure.

        * platform/gtk/Skipped:
        * platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt: Added.
        * platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt: Added.
        * platform/gtk/fast/forms/slider-thumb-stylability-expected.txt: Added.
        * platform/gtk/fast/forms/thumbslider-crash-expected.txt: Added.
        * platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt: Added.
2010-06-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Fix XFrameOptions and xssAuditor crashes in HTML5 parser
        https://bugs.webkit.org/show_bug.cgi?id=40265

        We're not supposed to call end() while the tokenizer's write() method.
        This causes a bunch of LayoutTests to crash.  In particular, this patch
        fixes crashes in the following tests:

        Tests:
          * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
          * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
          * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
          * http/tests/security/xssAuditor/full-block-base-href.html
          * http/tests/security/xssAuditor/full-block-get-from-iframe.html
          * http/tests/security/xssAuditor/full-block-iframe-javascript-url.html
          * http/tests/security/xssAuditor/full-block-link-onclick.html
          * http/tests/security/xssAuditor/full-block-post-from-iframe.html
          * http/tests/security/xssAuditor/full-block-script-tag.html
          * http/tests/security/xssAuditor/xss-protection-parsing-01.html

        * html/HTML5Tokenizer.cpp:
        (WebCore::):
        (WebCore::HTML5Tokenizer::HTML5Tokenizer):
        (WebCore::HTML5Tokenizer::write):
        (WebCore::HTML5Tokenizer::attemptToEnd):
        (WebCore::HTML5Tokenizer::endIfDelayed):
        (WebCore::HTML5Tokenizer::finish):
        (WebCore::HTML5Tokenizer::resumeParsingAfterScriptExecution):
        * html/HTML5Tokenizer.h:
        (WebCore::HTML5Tokenizer::inWrite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/platform/gtk/Skipped
LayoutTests/platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt [new file with mode: 0644]
LayoutTests/platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt [new file with mode: 0644]
LayoutTests/platform/gtk/fast/forms/slider-thumb-stylability-expected.txt [new file with mode: 0644]
LayoutTests/platform/gtk/fast/forms/thumbslider-crash-expected.txt [new file with mode: 0644]
LayoutTests/platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt [new file with mode: 0644]
WebCore/ChangeLog
WebCore/platform/gtk/RenderThemeGtk.cpp
WebCore/platform/gtk/RenderThemeGtk.h