[Payment Request] Remove PaymentAddress.languageCode
authoraestes@apple.com <aestes@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Sep 2018 04:25:11 +0000 (04:25 +0000)
committeraestes@apple.com <aestes@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Sep 2018 04:25:11 +0000 (04:25 +0000)
commitbcdf33364fc4bce6ce4420e1bdaee5863f4f319a
tree983de5a64b292e6e0a8e83f1f50664ab8aa25fcf
parentb00cc06fe57bbc4f6ad8d01b922f47070138bec7
[Payment Request] Remove PaymentAddress.languageCode
https://bugs.webkit.org/show_bug.cgi?id=189254

Reviewed by Sam Weinig.

Source/WebCore:

PaymentAddress.languageCode is marked as "at risk" in the latest Payment Request Editor's
Draft (30 August 2018). Firefox has already removed it, and Chrome is considering it.

There is some compatibility risk in removing this attribute, but considering we never
populated it with a meaningful value, the risk seems very low. If we learn about
compatibility problems, we can address them by evangelising or even reverting this change.

Updated existing tests.

* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::convert):
* Modules/paymentrequest/PaymentAddress.cpp:
(WebCore::PaymentAddress::PaymentAddress):
* Modules/paymentrequest/PaymentAddress.h:
* Modules/paymentrequest/PaymentAddress.idl:

LayoutTests:

* http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html:
* http/tests/ssl/applepay/ApplePayRequestShippingContact.https-expected.txt:
* http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
LayoutTests/http/tests/ssl/applepay/ApplePayRequestShippingContact.https-expected.txt
LayoutTests/http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html
Source/WebCore/ChangeLog
Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp
Source/WebCore/Modules/paymentrequest/PaymentAddress.cpp
Source/WebCore/Modules/paymentrequest/PaymentAddress.h
Source/WebCore/Modules/paymentrequest/PaymentAddress.idl