Remove remaining bits of dynamic <link> rel='icon' loading
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Apr 2016 01:33:34 +0000 (01:33 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Apr 2016 01:33:34 +0000 (01:33 +0000)
commitbb880c388e8fd7da5e68e4a2623059097e3a64ba
tree5f6d577ac631faacb8147b331c945e71c839397e
parent0431a729ff881edc000bb9c4763a21c65d216876
Remove remaining bits of dynamic <link> rel='icon' loading
https://bugs.webkit.org/show_bug.cgi?id=156727

Reviewed by Darin Adler.

Source/WebCore:

Don't call 'shouldLoadLink' for 'icon' link types. It performs no
useful checks for 'icon' types, and emits the non-standard
'onbeforeload' event.

This work finishes up https://webkit.org/b/153151, where we removed
FrameLoaderClient::dispatchDidChangeIcons() and related code.

Test: webarchive/test-link-rel-subresource-beforeload.html

* loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink): Remove unneeded call to 'shouldLoadLink'.

Tools:

Remove unused test infrastructure. This code never existed in WebKit2
testing since was only used on Windows.

* DumpRenderTree/TestRunner.cpp:
(dumpIconChangesCallback): Deleted.
* DumpRenderTree/TestRunner.h:
(TestRunner::dumpIconChanges): Deleted.
(TestRunner::setDumpIconChanges): Deleted.

LayoutTests:

Rename 'test-link-rel-icon-beforeload.html' to 'test-link-rel-subresource-beforeload.html'.

* fast/dom/icon-url-property-expected.txt: Removed.
* fast/dom/icon-url-property.html: Removed.
* platform/gtk/TestExpectations: Remove references to deleted tests.
* platform/ios-simulator/TestExpectations: Ditto.
* platform/wk2/TestExpectations: Ditto.
* webarchive/test-link-rel-icon-beforeload-expected.webarchive: Removed.
* webarchive/test-link-rel-icon-beforeload.html: Removed.
* webarchive/test-link-rel-subresource-beforeload-expected.webarchive: Copied from LayoutTests/webarchive/test-link-rel-icon-beforeload-expected.webarchive.
* webarchive/test-link-rel-subresource-beforeload.html: Copied from LayoutTests/webarchive/test-link-rel-icon-beforeload.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@199752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
13 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/dom/icon-url-property-expected.txt [deleted file]
LayoutTests/fast/dom/icon-url-property.html [deleted file]
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/ios-simulator/TestExpectations
LayoutTests/platform/wk2/TestExpectations
LayoutTests/webarchive/test-link-rel-subresource-beforeload-expected.webarchive [moved from LayoutTests/webarchive/test-link-rel-icon-beforeload-expected.webarchive with 83% similarity]
LayoutTests/webarchive/test-link-rel-subresource-beforeload.html [moved from LayoutTests/webarchive/test-link-rel-icon-beforeload.html with 79% similarity]
Source/WebCore/ChangeLog
Source/WebCore/loader/LinkLoader.cpp
Tools/ChangeLog
Tools/DumpRenderTree/TestRunner.cpp
Tools/DumpRenderTree/TestRunner.h