Remove CSS Animation Triggers
authordino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 2 Oct 2018 17:36:05 +0000 (17:36 +0000)
committerdino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 2 Oct 2018 17:36:05 +0000 (17:36 +0000)
commitba146068e7bcbad17ae89fafc401664925a01f63
tree4a76e9f036beadb8ce6dc25feb01ab71f13a862a
parent807226b8119f7d5e343c790a8c8b593d2e5388cf
Remove CSS Animation Triggers
https://bugs.webkit.org/show_bug.cgi?id=190175
<rdar://problem/44925626>

Reviewed by Simon Fraser.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Remove the never-properly specified CSS Animation Triggers.

* Configurations/FeatureDefines.xcconfig:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSAnimationTriggerScrollValue.cpp: Removed.
* css/CSSAnimationTriggerScrollValue.h: Removed.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
(WebCore::createAnimationTriggerValue): Deleted.
(WebCore::animationTriggerValue): Deleted.
* css/CSSProperties.json:
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTrigger): Deleted.
* css/CSSToStyleMap.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::equals const):
(WebCore::CSSValue::cssText const):
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::isAnimationTriggerScrollValue const): Deleted.
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeAnimationValue):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::consumeWebkitAnimationTrigger): Deleted.
* page/FrameView.cpp:
(WebCore::FrameView::sendScrollEvent):
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setAnimationTriggersEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::animationTriggersEnabled const): Deleted.
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::timeToNextService):
(WebCore::AnimationBase::getElapsedTime const):
* page/animation/CSSAnimationController.cpp:
(WebCore::CSSAnimationControllerPrivate::animationWillBeRemoved):
(WebCore::CSSAnimationControllerPrivate::addToAnimationsDependentOnScroll): Deleted.
(WebCore::CSSAnimationControllerPrivate::removeFromAnimationsDependentOnScroll): Deleted.
(WebCore::CSSAnimationControllerPrivate::scrollWasUpdated): Deleted.
(WebCore::CSSAnimationController::wantsScrollUpdates const): Deleted.
(WebCore::CSSAnimationController::scrollWasUpdated): Deleted.
* page/animation/CSSAnimationController.h:
* page/animation/CSSAnimationControllerPrivate.h:
(WebCore::CSSAnimationControllerPrivate::wantsScrollUpdates const): Deleted.
(WebCore::CSSAnimationControllerPrivate::scrollPosition const): Deleted.
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateKeyframeAnimations):
* page/animation/CompositeAnimation.h:
(WebCore::CompositeAnimation::hasScrollTriggeredAnimation const): Deleted.
* platform/animation/Animation.cpp:
(WebCore::Animation::Animation):
(WebCore::Animation::operator=):
(WebCore::Animation::animationsMatch const):
* platform/animation/Animation.h:
(WebCore::Animation::isTimingFunctionSet const):
(WebCore::Animation::isEmpty const):
(WebCore::Animation::clearTimingFunction):
(WebCore::Animation::clearAll):
(WebCore::Animation::animationMode const):
(WebCore::Animation::setAnimationMode):
(WebCore::Animation::initialTimingFunction):
(WebCore::Animation::isTriggerSet const): Deleted.
(WebCore::Animation::clearTrigger): Deleted.
(WebCore::Animation::trigger const): Deleted.
(WebCore::Animation::setTrigger): Deleted.
(WebCore::Animation::initialTrigger): Deleted.
* platform/animation/AnimationTrigger.h: Removed.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::animationCanBeAccelerated const):

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

Remove a bunch of tests that no longer have an implementation.

* TestExpectations:
* animations/trigger-computed-style-expected.txt: Removed.
* animations/trigger-computed-style.html: Removed.
* animations/trigger-container-scroll-boundaries-expected.txt: Removed.
* animations/trigger-container-scroll-boundaries.html: Removed.
* animations/trigger-container-scroll-empty-expected.txt: Removed.
* animations/trigger-container-scroll-empty.html: Removed.
* animations/trigger-container-scroll-simple-expected.txt: Removed.
* animations/trigger-container-scroll-simple.html: Removed.
* animations/trigger-parsing-expected.txt: Removed.
* animations/trigger-parsing.html: Removed.
* fast/css/compare-animation-trigger-expected.txt: Removed.
* fast/css/compare-animation-trigger.html: Removed.
* legacy-animation-engine/animations/trigger-computed-style-expected.txt: Removed.
* legacy-animation-engine/animations/trigger-computed-style.html: Removed.
* legacy-animation-engine/animations/trigger-container-scroll-boundaries-expected.txt: Removed.
* legacy-animation-engine/animations/trigger-container-scroll-boundaries.html: Removed.
* legacy-animation-engine/animations/trigger-container-scroll-empty-expected.txt: Removed.
* legacy-animation-engine/animations/trigger-container-scroll-empty.html: Removed.
* legacy-animation-engine/animations/trigger-container-scroll-simple-expected.txt: Removed.
* legacy-animation-engine/animations/trigger-container-scroll-simple.html: Removed.
* legacy-animation-engine/animations/trigger-parsing-expected.txt: Removed.
* legacy-animation-engine/animations/trigger-parsing.html: Removed.
* legacy-animation-engine/fast/css/compare-animation-trigger-expected.txt: Removed.
* legacy-animation-engine/fast/css/compare-animation-trigger.html: Removed.
* platform/gtk/TestExpectations:
* platform/ios/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
75 files changed:
LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/animations/trigger-computed-style-expected.txt [deleted file]
LayoutTests/animations/trigger-computed-style.html [deleted file]
LayoutTests/animations/trigger-container-scroll-boundaries-expected.txt [deleted file]
LayoutTests/animations/trigger-container-scroll-boundaries.html [deleted file]
LayoutTests/animations/trigger-container-scroll-empty-expected.txt [deleted file]
LayoutTests/animations/trigger-container-scroll-empty.html [deleted file]
LayoutTests/animations/trigger-container-scroll-simple-expected.txt [deleted file]
LayoutTests/animations/trigger-container-scroll-simple.html [deleted file]
LayoutTests/animations/trigger-parsing-expected.txt [deleted file]
LayoutTests/animations/trigger-parsing.html [deleted file]
LayoutTests/fast/css/compare-animation-trigger-expected.txt [deleted file]
LayoutTests/fast/css/compare-animation-trigger.html [deleted file]
LayoutTests/legacy-animation-engine/animations/trigger-computed-style-expected.txt [deleted file]
LayoutTests/legacy-animation-engine/animations/trigger-computed-style.html [deleted file]
LayoutTests/legacy-animation-engine/animations/trigger-container-scroll-boundaries-expected.txt [deleted file]
LayoutTests/legacy-animation-engine/animations/trigger-container-scroll-boundaries.html [deleted file]
LayoutTests/legacy-animation-engine/animations/trigger-container-scroll-empty-expected.txt [deleted file]
LayoutTests/legacy-animation-engine/animations/trigger-container-scroll-empty.html [deleted file]
LayoutTests/legacy-animation-engine/animations/trigger-container-scroll-simple-expected.txt [deleted file]
LayoutTests/legacy-animation-engine/animations/trigger-container-scroll-simple.html [deleted file]
LayoutTests/legacy-animation-engine/animations/trigger-parsing-expected.txt [deleted file]
LayoutTests/legacy-animation-engine/animations/trigger-parsing.html [deleted file]
LayoutTests/legacy-animation-engine/fast/css/compare-animation-trigger-expected.txt [deleted file]
LayoutTests/legacy-animation-engine/fast/css/compare-animation-trigger.html [deleted file]
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/ios-wk1/TestExpectations
LayoutTests/platform/ios/TestExpectations
LayoutTests/platform/mac-wk2/TestExpectations
LayoutTests/platform/win/TestExpectations
LayoutTests/platform/wincairo/TestExpectations
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/ChangeLog
Source/WebCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/PAL/ChangeLog
Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
Source/WebCore/Sources.txt
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/css/CSSAnimationTriggerScrollValue.cpp [deleted file]
Source/WebCore/css/CSSAnimationTriggerScrollValue.h [deleted file]
Source/WebCore/css/CSSComputedStyleDeclaration.cpp
Source/WebCore/css/CSSProperties.json
Source/WebCore/css/CSSToStyleMap.cpp
Source/WebCore/css/CSSToStyleMap.h
Source/WebCore/css/CSSValue.cpp
Source/WebCore/css/CSSValue.h
Source/WebCore/css/parser/CSSPropertyParser.cpp
Source/WebCore/page/FrameView.cpp
Source/WebCore/page/RuntimeEnabledFeatures.h
Source/WebCore/page/animation/AnimationBase.cpp
Source/WebCore/page/animation/CSSAnimationController.cpp
Source/WebCore/page/animation/CSSAnimationController.h
Source/WebCore/page/animation/CSSAnimationControllerPrivate.h
Source/WebCore/page/animation/CompositeAnimation.cpp
Source/WebCore/page/animation/CompositeAnimation.h
Source/WebCore/platform/animation/Animation.cpp
Source/WebCore/platform/animation/Animation.h
Source/WebCore/platform/animation/AnimationTrigger.h [deleted file]
Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
Source/WebKit/ChangeLog
Source/WebKit/Configurations/FeatureDefines.xcconfig
Source/WebKit/Shared/WebPreferences.yaml
Source/WebKit/UIProcess/API/C/WKPreferences.cpp
Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.h
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
Source/cmake/WebKitFeatures.cmake
Tools/ChangeLog
Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig