2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
authorcaio.oliveira@openbossa.org <caio.oliveira@openbossa.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 Jun 2011 12:16:09 +0000 (12:16 +0000)
committercaio.oliveira@openbossa.org <caio.oliveira@openbossa.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 Jun 2011 12:16:09 +0000 (12:16 +0000)
commitb7dd30d6bffd49cb42b7ce2ce1a9b417f5350308
tree256badee9fced98100a83f5c6dbd2d4973a364dc
parent2b6f82825a4c8d75cc1c54b53e7b10a27a4c7cfa
2011-06-01  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Tor Arne Vestbø.

        [Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals
        https://bugs.webkit.org/show_bug.cgi?id=61739

        The skipped test was imported from Qt source repository, and used private headers
        to peek in the QML Grid element. This patch changes the QML used to expose the
        information we want to test: number of pages opened and the first page opened.

        * tests/qdeclarativewebview/resources/newwindows.html:
        Added <body> tags. We have no reason to not use them in the test.

        * tests/qdeclarativewebview/resources/newwindows.qml:
        Moved the timer out of the page component, used anchors for setting webview size,
        changed the way we count pages opened. Also changed coding style a bit.

        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
        (tst_QDeclarativeWebView::multipleWindows):
        We now look for properties with the information we want in the rootItem: pagesOpened and
        firstPageOpened.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebKit/qt/ChangeLog
Source/WebKit/qt/tests/qdeclarativewebview/resources/newwindows.html
Source/WebKit/qt/tests/qdeclarativewebview/resources/newwindows.qml
Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp