Web Inspector: Adopt ES6 Class Syntax for all Model Objects
authorjoepeck@webkit.org <joepeck@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Mar 2015 00:18:15 +0000 (00:18 +0000)
committerjoepeck@webkit.org <joepeck@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Mar 2015 00:18:15 +0000 (00:18 +0000)
commitb25ec36612cf2834722d8a8d85b37cd817d3e961
treebd7afbb525544c83a99f51821cd65d2304f88fc3
parent24af9f9403987db8d359a5a37835b03157892942
Web Inspector: Adopt ES6 Class Syntax for all Model Objects
https://bugs.webkit.org/show_bug.cgi?id=142858

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

  - Convert WebInspector.Object to a class
  - Convert all UserInterface/Models objects to classes
  - Convert constructor functions to constructor methods
  - Convert "constructor.method" to class static methods where possible
  - Convert all methods to method syntax, eliminate commas between methods
  - Convert all superclass calls in classes to use "super"
  - Workaround <https://webkit.org/b/142862> and add empty constructors
  - Added "deprecated" prefix to addConstructorFunctions, since it is not needed with classes
  - Added many missing calls to super in constructors
  - Added FIXME to WebInspector.Object subclasses not yet moved to classes.
  - Cleaned up SourceMap global properties, moved to constructor instead of prototype
  - Cleaned up Timeline factory constructor to static "create" factory method
  - Fixed any style issues noticed in the mass edit
  - Fixed strict mode issues now that classes enforce strict mode
      - RunLoopTimelineRecord.js was missing a `var` for a local variable
      - "const" is not allowed, converted to "var"
      - "arguments.callee" is not allowed in strict mode

* UserInterface/**/*.js:
Many files modified mostly mechanically.

LayoutTests:

* inspector/model/parse-script-syntax-tree.html:
This test was calling a constructor without "new". Class
syntax enforces "new" and threw an exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
182 files changed:
LayoutTests/ChangeLog
LayoutTests/inspector/model/parse-script-syntax-tree.html
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Base/Object.js
Source/WebInspectorUI/UserInterface/Base/Test.js
Source/WebInspectorUI/UserInterface/Controllers/AnalyzerManager.js
Source/WebInspectorUI/UserInterface/Controllers/Annotator.js
Source/WebInspectorUI/UserInterface/Controllers/ApplicationCacheManager.js
Source/WebInspectorUI/UserInterface/Controllers/BranchManager.js
Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js
Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js
Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorEditingController.js
Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js
Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js
Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js
Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js
Source/WebInspectorUI/UserInterface/Controllers/FormatterSourceMap.js
Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js
Source/WebInspectorUI/UserInterface/Controllers/IssueManager.js
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js
Source/WebInspectorUI/UserInterface/Controllers/LayerTreeManager.js
Source/WebInspectorUI/UserInterface/Controllers/LogManager.js
Source/WebInspectorUI/UserInterface/Controllers/ProbeManager.js
Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js
Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js
Source/WebInspectorUI/UserInterface/Controllers/SourceMapManager.js
Source/WebInspectorUI/UserInterface/Controllers/StorageManager.js
Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
Source/WebInspectorUI/UserInterface/Models/AnalyzerMessage.js
Source/WebInspectorUI/UserInterface/Models/ApplicationCacheFrame.js
Source/WebInspectorUI/UserInterface/Models/ApplicationCacheManifest.js
Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js
Source/WebInspectorUI/UserInterface/Models/Branch.js
Source/WebInspectorUI/UserInterface/Models/Breakpoint.js
Source/WebInspectorUI/UserInterface/Models/BreakpointAction.js
Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js
Source/WebInspectorUI/UserInterface/Models/CSSMedia.js
Source/WebInspectorUI/UserInterface/Models/CSSProperty.js
Source/WebInspectorUI/UserInterface/Models/CSSRule.js
Source/WebInspectorUI/UserInterface/Models/CSSSelector.js
Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js
Source/WebInspectorUI/UserInterface/Models/CSSStyleSheet.js
Source/WebInspectorUI/UserInterface/Models/CallFrame.js
Source/WebInspectorUI/UserInterface/Models/CollectionEntry.js
Source/WebInspectorUI/UserInterface/Models/CollectionEntryPreview.js
Source/WebInspectorUI/UserInterface/Models/Color.js
Source/WebInspectorUI/UserInterface/Models/ContentFlow.js
Source/WebInspectorUI/UserInterface/Models/CookieStorageObject.js
Source/WebInspectorUI/UserInterface/Models/DOMNode.js
Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js
Source/WebInspectorUI/UserInterface/Models/DOMSearchMatchObject.js
Source/WebInspectorUI/UserInterface/Models/DOMStorageObject.js
Source/WebInspectorUI/UserInterface/Models/DOMTree.js
Source/WebInspectorUI/UserInterface/Models/DatabaseObject.js
Source/WebInspectorUI/UserInterface/Models/DatabaseTableObject.js
Source/WebInspectorUI/UserInterface/Models/DebuggerDashboard.js
Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js
Source/WebInspectorUI/UserInterface/Models/ExecutionContext.js
Source/WebInspectorUI/UserInterface/Models/ExecutionContextList.js
Source/WebInspectorUI/UserInterface/Models/Frame.js
Source/WebInspectorUI/UserInterface/Models/Geometry.js
Source/WebInspectorUI/UserInterface/Models/Gradient.js
Source/WebInspectorUI/UserInterface/Models/IndexedDatabase.js
Source/WebInspectorUI/UserInterface/Models/IndexedDatabaseObjectStore.js
Source/WebInspectorUI/UserInterface/Models/IndexedDatabaseObjectStoreIndex.js
Source/WebInspectorUI/UserInterface/Models/IssueMessage.js
Source/WebInspectorUI/UserInterface/Models/KeyboardShortcut.js
Source/WebInspectorUI/UserInterface/Models/LayoutTimelineRecord.js
Source/WebInspectorUI/UserInterface/Models/LazySourceCodeLocation.js
Source/WebInspectorUI/UserInterface/Models/LineWidget.js
Source/WebInspectorUI/UserInterface/Models/LogObject.js
Source/WebInspectorUI/UserInterface/Models/NetworkTimeline.js
Source/WebInspectorUI/UserInterface/Models/ObjectPreview.js
Source/WebInspectorUI/UserInterface/Models/Probe.js
Source/WebInspectorUI/UserInterface/Models/ProbeSet.js
Source/WebInspectorUI/UserInterface/Models/ProbeSetDataFrame.js
Source/WebInspectorUI/UserInterface/Models/ProbeSetDataTable.js
Source/WebInspectorUI/UserInterface/Models/Profile.js
Source/WebInspectorUI/UserInterface/Models/ProfileNode.js
Source/WebInspectorUI/UserInterface/Models/ProfileNodeCall.js
Source/WebInspectorUI/UserInterface/Models/PropertyDescriptor.js
Source/WebInspectorUI/UserInterface/Models/PropertyPath.js
Source/WebInspectorUI/UserInterface/Models/PropertyPreview.js
Source/WebInspectorUI/UserInterface/Models/ReplayDashboard.js
Source/WebInspectorUI/UserInterface/Models/ReplaySession.js
Source/WebInspectorUI/UserInterface/Models/ReplaySessionSegment.js
Source/WebInspectorUI/UserInterface/Models/Resource.js
Source/WebInspectorUI/UserInterface/Models/ResourceCollection.js
Source/WebInspectorUI/UserInterface/Models/ResourceTimelineRecord.js
Source/WebInspectorUI/UserInterface/Models/Revision.js
Source/WebInspectorUI/UserInterface/Models/RunLoopTimelineRecord.js
Source/WebInspectorUI/UserInterface/Models/ScopeChainNode.js
Source/WebInspectorUI/UserInterface/Models/Script.js
Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js
Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js
Source/WebInspectorUI/UserInterface/Models/Setting.js
Source/WebInspectorUI/UserInterface/Models/SourceCode.js
Source/WebInspectorUI/UserInterface/Models/SourceCodeLocation.js
Source/WebInspectorUI/UserInterface/Models/SourceCodePosition.js
Source/WebInspectorUI/UserInterface/Models/SourceCodeRevision.js
Source/WebInspectorUI/UserInterface/Models/SourceCodeSearchMatchObject.js
Source/WebInspectorUI/UserInterface/Models/SourceCodeTextRange.js
Source/WebInspectorUI/UserInterface/Models/SourceCodeTimeline.js
Source/WebInspectorUI/UserInterface/Models/SourceMap.js
Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js
Source/WebInspectorUI/UserInterface/Models/TextMarker.js
Source/WebInspectorUI/UserInterface/Models/TextRange.js
Source/WebInspectorUI/UserInterface/Models/Timeline.js
Source/WebInspectorUI/UserInterface/Models/TimelineMarker.js
Source/WebInspectorUI/UserInterface/Models/TimelineRecord.js
Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js
Source/WebInspectorUI/UserInterface/Models/TypeSet.js
Source/WebInspectorUI/UserInterface/Models/UnitBezier.js
Source/WebInspectorUI/UserInterface/Protocol/ApplicationCacheObserver.js
Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js
Source/WebInspectorUI/UserInterface/Protocol/ConsoleObserver.js
Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js
Source/WebInspectorUI/UserInterface/Protocol/DOMStorageObserver.js
Source/WebInspectorUI/UserInterface/Protocol/DatabaseObserver.js
Source/WebInspectorUI/UserInterface/Protocol/DebuggerObserver.js
Source/WebInspectorUI/UserInterface/Protocol/InspectorObserver.js
Source/WebInspectorUI/UserInterface/Protocol/LayerTreeObserver.js
Source/WebInspectorUI/UserInterface/Protocol/NetworkObserver.js
Source/WebInspectorUI/UserInterface/Protocol/PageObserver.js
Source/WebInspectorUI/UserInterface/Protocol/ReplayObserver.js
Source/WebInspectorUI/UserInterface/Protocol/RuntimeObserver.js
Source/WebInspectorUI/UserInterface/Protocol/TimelineObserver.js
Source/WebInspectorUI/UserInterface/Test.html
Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.js
Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js
Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js
Source/WebInspectorUI/UserInterface/Views/ColorPicker.js
Source/WebInspectorUI/UserInterface/Views/ColorWheel.js
Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js
Source/WebInspectorUI/UserInterface/Views/ConsoleCommand.js
Source/WebInspectorUI/UserInterface/Views/ConsoleGroup.js
Source/WebInspectorUI/UserInterface/Views/ConsolePrompt.js
Source/WebInspectorUI/UserInterface/Views/ConsoleSession.js
Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js
Source/WebInspectorUI/UserInterface/Views/ContentView.js
Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js
Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js
Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.js
Source/WebInspectorUI/UserInterface/Views/DashboardView.js
Source/WebInspectorUI/UserInterface/Views/DetailsSection.js
Source/WebInspectorUI/UserInterface/Views/DetailsSectionGroup.js
Source/WebInspectorUI/UserInterface/Views/DetailsSectionRow.js
Source/WebInspectorUI/UserInterface/Views/FilterBar.js
Source/WebInspectorUI/UserInterface/Views/FindBanner.js
Source/WebInspectorUI/UserInterface/Views/GoToLineDialog.js
Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js
Source/WebInspectorUI/UserInterface/Views/HoverMenu.js
Source/WebInspectorUI/UserInterface/Views/IndeterminateProgressSpinner.js
Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js
Source/WebInspectorUI/UserInterface/Views/NavigationBar.js
Source/WebInspectorUI/UserInterface/Views/NavigationItem.js
Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js
Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js
Source/WebInspectorUI/UserInterface/Views/Popover.js
Source/WebInspectorUI/UserInterface/Views/ProfileNodeDataGridNode.js
Source/WebInspectorUI/UserInterface/Views/QuickConsole.js
Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js
Source/WebInspectorUI/UserInterface/Views/ScopeBarItem.js
Source/WebInspectorUI/UserInterface/Views/ScriptTimelineDataGridNode.js
Source/WebInspectorUI/UserInterface/Views/Section.js
Source/WebInspectorUI/UserInterface/Views/Sidebar.js
Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js
Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
Source/WebInspectorUI/UserInterface/Views/SourceCodeTimelineTimelineDataGridNode.js
Source/WebInspectorUI/UserInterface/Views/TextEditor.js
Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js
Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js
Source/WebInspectorUI/UserInterface/Views/TimelineOverviewGraph.js
Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js
Source/WebInspectorUI/UserInterface/Views/TimelineRecordFrame.js
Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js
Source/WebInspectorUI/UserInterface/Views/Toolbar.js
Source/WebInspectorUI/UserInterface/Views/TreeElementStatusButton.js
Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
Source/WebInspectorUI/UserInterface/Views/TreeOutlineDataGridSynchronizer.js
Source/WebInspectorUI/UserInterface/Views/TypeTokenView.js