2010-09-12 Adam Barth <abarth@webkit.org>
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 13 Sep 2010 01:04:35 +0000 (01:04 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 13 Sep 2010 01:04:35 +0000 (01:04 +0000)
commitaf6d3592ee8e5c4127784a5b553332fb7f424d43
treec9e6e858756c294e2e43a077ebe49b81ee5412b8
parent7b0dcc2ae80b929b0335831304b47da608d42665
2010-09-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Adoption agency should use takeAllChildrenFrom
        https://bugs.webkit.org/show_bug.cgi?id=45570

        Before this patch, we were using an unsafe pattern of walking the
        sibling list without grabbing references.  Instead, we should use the
        shiny new takeAllChildrenFrom method that shoves the children into a
        vector first.  Also, update takeAllChildrenFrom to handle the case
        where the old parent is attached.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::takeAllChildrenFrom):
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
        * html/parser/HTMLTreeBuilder.h:
2010-09-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Adoption agency should use takeAllChildrenFrom
        https://bugs.webkit.org/show_bug.cgi?id=45570

        More test cases.

        * html5lib/resources/webkit01.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/html5lib/resources/webkit01.dat
LayoutTests/platform/mac/http/tests/navigation/post-goback1-expected.txt
LayoutTests/platform/mac/http/tests/navigation/postredirect-basic-expected.txt
LayoutTests/platform/mac/http/tests/navigation/postredirect-frames-expected.txt
LayoutTests/platform/mac/http/tests/navigation/postredirect-goback1-expected.txt
WebCore/ChangeLog
WebCore/dom/ContainerNode.cpp
WebCore/html/parser/HTMLTreeBuilder.cpp
WebCore/html/parser/HTMLTreeBuilder.h