REGRESSION(r234620): SVGLangSpace::svgAttributeChanged() should invalidate the render...
authorsaid@apple.com <said@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Oct 2018 23:59:52 +0000 (23:59 +0000)
committersaid@apple.com <said@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Oct 2018 23:59:52 +0000 (23:59 +0000)
commitac8213155333882aeb2e8cf135589bb475c20897
tree07f7b640d9f9be337cf3679e881a33c2f49681bf
parentcc7531b092129195add844a5b5713579f6740a75
REGRESSION(r234620): SVGLangSpace::svgAttributeChanged() should invalidate the renderer of the SVGGeometryElement descendant only
https://bugs.webkit.org/show_bug.cgi?id=190411

Reviewed by Simon Fraser.

Source/WebCore:

Test: svg/dynamic-updates/SVGStopElement-dom-xml-lang-attrr.html

When changing the attributes of the SVGLangSpace, we should invalidate
the renderer of the SVGGeometryElement descendant only. Renderer of other
elements, like SVGStopElement, should not be invalidated because they do
not have geometry and they can be used as resources for drawing another
SVGGeometryElement.

* svg/SVGElement.h:
(WebCore::SVGElement::isSVGGeometryElement const):
* svg/SVGGeometryElement.h:
(isType):
* svg/SVGLangSpace.cpp:
(WebCore::SVGLangSpace::svgAttributeChanged):

LayoutTests:

* svg/dynamic-updates/SVGStopElement-dom-xml-lang-attrr-expected.txt: Added.
* svg/dynamic-updates/SVGStopElement-dom-xml-lang-attrr.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/svg/dynamic-updates/SVGStopElement-dom-xml-lang-attrr-expected.txt [new file with mode: 0644]
LayoutTests/svg/dynamic-updates/SVGStopElement-dom-xml-lang-attrr.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/svg/SVGElement.h
Source/WebCore/svg/SVGGeometryElement.h
Source/WebCore/svg/SVGLangSpace.cpp