REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
authorjchaffraix@webkit.org <jchaffraix@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Sep 2012 23:39:00 +0000 (23:39 +0000)
committerjchaffraix@webkit.org <jchaffraix@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Sep 2012 23:39:00 +0000 (23:39 +0000)
commitab760575d20c6c40d57a0891f9d7874f22e4dbd8
tree750ef141664688697e334ef68f7f954e43587396
parent574a2240a013cc2b37db1ca32b5f33fd4b4b4c71
REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
https://bugs.webkit.org/show_bug.cgi?id=95776

Reviewed by Simon Fraser.

.:

* ManualTests/select-menu-list-wrongly-positioned.html: Added.

Source/WebCore:

r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.

Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ChangeLog
ManualTests/select-menu-list-wrongly-positioned.html [new file with mode: 0755]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderLayer.cpp