Clean up virtual functions in css/
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Oct 2014 23:08:20 +0000 (23:08 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Oct 2014 23:08:20 +0000 (23:08 +0000)
commitaaa49c9e84b561db1ed0dec4cf51740693c8fddd
tree4feb34748343d8dad92ad0544a6a5bf88db55b78
parentce4bbbe0690ea0a69306fac21601f7b824b0ffa2
Clean up virtual functions in css/
https://bugs.webkit.org/show_bug.cgi?id=138230

Reviewed by Benjamin Poulain.

Clean up virtual functions in css/ by:
- Making virtual functions final when possible
- Making classes final when possible
- Using 'override' when appropriate
- Explicitly marking functions / destructors as virtual when they are
  inherently virtual
- Making isXXX() virtual functions private on XXX classes to avoid
  unnecessary type checks

No new tests, no behavior change.

* WebCore.exp.in:
* css/CSSBasicShapes.h:
* css/CSSCharsetRule.h:
* css/CSSComputedStyleDeclaration.h:
* css/CSSCrossfadeValue.h:
* css/CSSFilterImageValue.h:
* css/CSSFontFaceLoadEvent.h:
* css/CSSFontFaceRule.h:
* css/CSSFontFaceSource.h:
* css/CSSImportRule.h:
* css/CSSMediaRule.h:
* css/CSSPageRule.h:
* css/CSSRuleList.h:
(WebCore::StaticCSSRuleList::ref): Deleted.
(WebCore::StaticCSSRuleList::styleSheet): Deleted.
(WebCore::StaticCSSRuleList::length): Deleted.
(WebCore::StaticCSSRuleList::item): Deleted.
(WebCore::LiveCSSRuleList::ref): Deleted.
(WebCore::LiveCSSRuleList::deref): Deleted.
(WebCore::LiveCSSRuleList::length): Deleted.
(WebCore::LiveCSSRuleList::item): Deleted.
(WebCore::LiveCSSRuleList::styleSheet): Deleted.
* css/CSSStyleRule.h:
* css/CSSSupportsRule.h:
* css/CSSUnknownRule.h:
* css/FontLoader.h:
* css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::parentElement):
* css/WebKitCSSKeyframeRule.h:
* css/WebKitCSSViewportRule.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@175391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
21 files changed:
Source/WebCore/ChangeLog
Source/WebCore/WebCore.exp.in
Source/WebCore/css/CSSBasicShapes.h
Source/WebCore/css/CSSCharsetRule.h
Source/WebCore/css/CSSComputedStyleDeclaration.h
Source/WebCore/css/CSSCrossfadeValue.h
Source/WebCore/css/CSSFilterImageValue.h
Source/WebCore/css/CSSFontFaceLoadEvent.h
Source/WebCore/css/CSSFontFaceRule.h
Source/WebCore/css/CSSFontFaceSource.h
Source/WebCore/css/CSSImportRule.h
Source/WebCore/css/CSSMediaRule.h
Source/WebCore/css/CSSPageRule.h
Source/WebCore/css/CSSRuleList.h
Source/WebCore/css/CSSStyleRule.h
Source/WebCore/css/CSSSupportsRule.h
Source/WebCore/css/CSSUnknownRule.h
Source/WebCore/css/FontLoader.h
Source/WebCore/css/PropertySetCSSStyleDeclaration.h
Source/WebCore/css/WebKitCSSKeyframeRule.h
Source/WebCore/css/WebKitCSSViewportRule.h