Roll out r121610 and r122487 which may have been causing flaky crashes
authorjsbell@chromium.org <jsbell@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 19 Jul 2012 16:24:41 +0000 (16:24 +0000)
committerjsbell@chromium.org <jsbell@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 19 Jul 2012 16:24:41 +0000 (16:24 +0000)
commita7161317436544aef36af6b1a178d46a73776dfd
treea27d112239ef537c5f38d32e58daf19bcd392be5
parentc2ea2c157a04c14474095675480660f349b56bed
Roll out r121610 and r122487 which may have been causing flaky crashes
https://bugs.webkit.org/show_bug.cgi?id=91637

Reviewed by Kentaro Hara.

Flaky crashes started in random tests following r121610. It's not clear
that r121610 is to blame, but we'd like to prove or disprove it.
If this doesn't resolve the crashes, this patch should be rolled out.

Source/WebCore:

* WebCore.gypi:
* bindings/v8/NPObjectWrapper.cpp: Added.
(WebCore):
(NPProxyObject):
(WebCore::NPObjectWrapper::NPObjectWrapper):
(WebCore::NPObjectWrapper::create):
(WebCore::NPObjectWrapper::clear):
(WebCore::NPObjectWrapper::getWrapper):
(WebCore::NPObjectWrapper::getUnderlyingNPObject):
(WebCore::NPObjectWrapper::getObjectForCall):
(WebCore::NPObjectWrapper::NPAllocate):
(WebCore::NPObjectWrapper::NPDeallocate):
(WebCore::NPObjectWrapper::NPPInvalidate):
(WebCore::NPObjectWrapper::NPHasMethod):
(WebCore::NPObjectWrapper::NPInvoke):
(WebCore::NPObjectWrapper::NPInvokeDefault):
(WebCore::NPObjectWrapper::NPHasProperty):
(WebCore::NPObjectWrapper::NPGetProperty):
(WebCore::NPObjectWrapper::NPSetProperty):
(WebCore::NPObjectWrapper::NPRemoveProperty):
(WebCore::NPObjectWrapper::NPNEnumerate):
(WebCore::NPObjectWrapper::NPNConstruct):
(WebCore::NPObjectWrapper::NPInvokePrivate):
* bindings/v8/NPObjectWrapper.h: Added.
(WebCore):
(NPObjectWrapper):
* bindings/v8/NPV8Object.cpp:
(WebCore::freeV8NPObject):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_EvaluateHelper):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_Enumerate):
(_NPN_Construct):
* bindings/v8/NPV8Object.h:
(WebCore):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::windowScriptNPObject):
* bindings/v8/ScriptController.h:
(ScriptController):

Source/WebKit/chromium:

* src/WebBindings.cpp:
(WebKit::getRangeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):
(WebKit::WebBindings::toV8Value):

Tools:

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
(PluginTest):
* DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Removed.

LayoutTests:

* plugins/npruntime/leak-window-scriptable-object-expected.txt: Removed.
* plugins/npruntime/leak-window-scriptable-object.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
18 files changed:
LayoutTests/ChangeLog
LayoutTests/plugins/npruntime/leak-window-scriptable-object-expected.txt [deleted file]
LayoutTests/plugins/npruntime/leak-window-scriptable-object.html [deleted file]
Source/WebCore/ChangeLog
Source/WebCore/WebCore.gypi
Source/WebCore/bindings/v8/NPObjectWrapper.cpp [new file with mode: 0644]
Source/WebCore/bindings/v8/NPObjectWrapper.h [new file with mode: 0644]
Source/WebCore/bindings/v8/NPV8Object.cpp
Source/WebCore/bindings/v8/NPV8Object.h
Source/WebCore/bindings/v8/ScriptController.cpp
Source/WebCore/bindings/v8/ScriptController.h
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/WebBindings.cpp
Tools/ChangeLog
Tools/DumpRenderTree/DumpRenderTree.gypi
Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp
Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h
Tools/DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp [deleted file]