media/track/track-in-band-style.html is flaky
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Mar 2019 20:05:33 +0000 (20:05 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Mar 2019 20:05:33 +0000 (20:05 +0000)
commita6286836e8b1db6a35d427cda8813e585639c336
tree8c662fd2c81fa7cda74806fc4524ade5f4d6f26b
parent2a56b1afc927fd439b223a097946ba8cd360aa16
media/track/track-in-band-style.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=195922

Reviewed by Eric Carlson.

Source/WebCore:

* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes):
Small optimization: some of the if checks were missing their "continue;"
statement. This would cause us to keep checking following keys even though
we already got a match.

LayoutTests:

* media/track/track-in-band-style-expected.txt:
* media/track/track-in-band-style.html:
- Check element.style instead of getComputedStyle(element) to get the
  CSS colors as this seems more reliable.
- For the foreground text color, check cueNode.style.color instead of
  cueDisplayElement given that the implementation sets the CSS attribute
  on the cueNode, not the cueDisplayElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/media/track/track-in-band-style-expected.txt
LayoutTests/media/track/track-in-band-style.html
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp