AX: doAXRangeForLine does not work
authorcfleizach@apple.com <cfleizach@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Oct 2010 21:03:21 +0000 (21:03 +0000)
committercfleizach@apple.com <cfleizach@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Oct 2010 21:03:21 +0000 (21:03 +0000)
commita615996edd5a93d34745f4069e6220064779f582
tree70942b68b5db810e40c18876142feebdd93ccf95
parent864fec3cdb380f37b1eca66104a96b7fb2a3dc37
AX: doAXRangeForLine does not work
https://bugs.webkit.org/show_bug.cgi?id=47101

Reviewed by Beth Dakin.

WebCore:

Asking for NSAccessibilityRangeForLine was returning a null range for any line number > 0.
The code was using a SelectionController to extend to the next line. Rather than change the implementation
of that core functionality, it is cleaner to use endOfLine to find the end of the line.

Test: platform/mac/accessibility/range-for-line-textarea.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::doAXRangeForLine):

WebKitTools:

DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.

* DumpRenderTree/AccessibilityUIElement.cpp:
(rangeForLineCallback):
(AccessibilityUIElement::rangeForLine):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::rangeForLine):

LayoutTests:

* platform/mac/accessibility/range-for-line-textarea-expected.txt: Added.
* platform/mac/accessibility/range-for-line-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/platform/mac/accessibility/range-for-line-textarea-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/accessibility/range-for-line-textarea.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/accessibility/AccessibilityRenderObject.cpp
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp
WebKitTools/DumpRenderTree/AccessibilityUIElement.h
WebKitTools/DumpRenderTree/mac/AccessibilityUIElementMac.mm