Text markers don't paint on simple lines
authorantti@apple.com <antti@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 May 2014 13:05:20 +0000 (13:05 +0000)
committerantti@apple.com <antti@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 May 2014 13:05:20 +0000 (13:05 +0000)
commita50f16a6b080abdb1c91a13f8e5e366b39acb0c6
treeb9427156fe5aac1db8a7f465563727e51cc1d204
parent6c804ccc1556012913ce9429dd97852ab47e53ff
Text markers don't paint on simple lines
https://bugs.webkit.org/show_bug.cgi?id=133177

Reviewed by Anders Carlsson.

Source/WebCore:

Marker painting code does not yet support simple lines.

Tests: fast/text/mark-matches-rendering-simple-lines.html
       fast/text/mark-matches-rendering.html

* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addMarker):

    Force text blocks with markers to use line boxes.

* testing/Internals.cpp:
(WebCore::Internals::setMarkedTextMatchesAreHighlighted):

    Expose this so we can make reftests for marker rendering.

* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* fast/text/mark-matches-rendering-expected.html: Added.
* fast/text/mark-matches-rendering-simple-lines-expected.html: Added.
* fast/text/mark-matches-rendering-simple-lines.html: Added.
* fast/text/mark-matches-rendering.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/text/mark-matches-rendering-expected.html [new file with mode: 0644]
LayoutTests/fast/text/mark-matches-rendering-simple-lines-expected.html [new file with mode: 0644]
LayoutTests/fast/text/mark-matches-rendering-simple-lines.html [new file with mode: 0644]
LayoutTests/fast/text/mark-matches-rendering.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/dom/DocumentMarkerController.cpp
Source/WebCore/testing/Internals.cpp
Source/WebCore/testing/Internals.h
Source/WebCore/testing/Internals.idl