Web Inspector: Add tests for DOM highlight commands
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 5 Sep 2015 02:38:42 +0000 (02:38 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 5 Sep 2015 02:38:42 +0000 (02:38 +0000)
commita340a74ce716821284fcc64adbdb49aaaa169d2b
tree7a67879ee32fae519dc29dd9d18d0968eb94ed2f
parentd8836427a6c6b208165780caea345bb1f45967fa
Web Inspector: Add tests for DOM highlight commands
https://bugs.webkit.org/show_bug.cgi?id=148786

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-09-04
Reviewed by Timothy Hatcher.

Source/WebCore:

Tests: inspector/dom/hideHighlight.html
       inspector/dom/highlightFrame.html
       inspector/dom/highlightNode.html
       inspector/dom/highlightQuad.html
       inspector/dom/highlightRect.html

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
Include an error if a frame is not found.

* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::highlightQuad):
Should have been checking the usePageCoordinates state of the incoming
highlight configuration, not the one that will be replaced.

LayoutTests:

* inspector/dom/hideHighlight-expected.txt: Added.
* inspector/dom/hideHighlight.html: Added.
* inspector/dom/highlightFrame-expected.txt: Added.
* inspector/dom/highlightFrame.html: Added.
* inspector/dom/highlightNode-expected.txt: Added.
* inspector/dom/highlightNode.html: Added.
* inspector/dom/highlightQuad-expected.txt: Added.
* inspector/dom/highlightQuad.html: Added.
* inspector/dom/highlightRect-expected.txt: Added.
* inspector/dom/highlightRect.html: Added.
* inspector/dom/highlightSelector-expected.txt:
* inspector/dom/highlightSelector.html:
* inspector/dom/resources/highlight-iframe.html: Renamed from LayoutTests/inspector/dom/resources/highlightSelector-iframe.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
18 files changed:
LayoutTests/ChangeLog
LayoutTests/inspector/dom/hideHighlight-expected.txt [new file with mode: 0644]
LayoutTests/inspector/dom/hideHighlight.html [new file with mode: 0644]
LayoutTests/inspector/dom/highlightFrame-expected.txt [new file with mode: 0644]
LayoutTests/inspector/dom/highlightFrame.html [new file with mode: 0644]
LayoutTests/inspector/dom/highlightNode-expected.txt [new file with mode: 0644]
LayoutTests/inspector/dom/highlightNode.html [new file with mode: 0644]
LayoutTests/inspector/dom/highlightQuad-expected.txt [new file with mode: 0644]
LayoutTests/inspector/dom/highlightQuad.html [new file with mode: 0644]
LayoutTests/inspector/dom/highlightRect-expected.txt [new file with mode: 0644]
LayoutTests/inspector/dom/highlightRect.html [new file with mode: 0644]
LayoutTests/inspector/dom/highlightSelector-expected.txt
LayoutTests/inspector/dom/highlightSelector.html
LayoutTests/inspector/dom/resources/highlight-iframe.html [new file with mode: 0644]
LayoutTests/inspector/dom/resources/highlightSelector-iframe.html [deleted file]
Source/WebCore/ChangeLog
Source/WebCore/inspector/InspectorDOMAgent.cpp
Source/WebCore/inspector/InspectorOverlay.cpp