[GTK] Issues with Ahem's ex / x-height
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 4 Jan 2018 10:04:31 +0000 (10:04 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 4 Jan 2018 10:04:31 +0000 (10:04 +0000)
commita108b706e11a9cc25ff2c0ca95c1a0f4adae39c2
tree324fc87c50d91b07a6b5a1df49038f81ebc1a0cf
parent4d064c45ee6e5e06d83fc0fcfc0a3fcbf9f930f6
[GTK] Issues with Ahem's ex / x-height
https://bugs.webkit.org/show_bug.cgi?id=180581

Reviewed by Michael Catanzaro.

Source/WebCore:

Get the x-height value from the TT_OS2 table if available.

Fixes: fast/text/break-word-pre-wrap.html
       imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-shape-arguments-000.html

* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::Font::platformInit):

LayoutTests:

Unskip two tests that are now passing and rebaseline others.

* platform/gtk/TestExpectations:
* platform/gtk/css1/font_properties/font_size-expected.png:
* platform/gtk/css1/font_properties/font_size-expected.txt:
* platform/gtk/css1/text_properties/letter_spacing-expected.png:
* platform/gtk/css1/text_properties/letter_spacing-expected.txt:
* platform/gtk/css1/text_properties/line_height-expected.png:
* platform/gtk/css1/text_properties/line_height-expected.txt:
* platform/gtk/css1/text_properties/text_indent-expected.png:
* platform/gtk/css1/text_properties/text_indent-expected.txt:
* platform/gtk/css1/text_properties/word_spacing-expected.png:
* platform/gtk/css1/text_properties/word_spacing-expected.txt:
* platform/gtk/css1/units/length_units-expected.png:
* platform/gtk/css1/units/length_units-expected.txt:
* platform/gtk/css2.1/t040302-c61-ex-len-00-b-a-expected.png:
* platform/gtk/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
* platform/gtk/css2.1/t040302-c61-rel-len-00-b-ag-expected.png:
* platform/gtk/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt:
* platform/gtk/css2.1/t1008-c44-ln-box-02-d-ag-expected.png:
* platform/gtk/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt:
* platform/gtk/css2.1/t100801-c544-valgn-01-d-ag-expected.png:
* platform/gtk/css2.1/t100801-c544-valgn-01-d-ag-expected.txt:
* platform/gtk/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/gtk/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
* platform/gtk/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png:
* platform/gtk/css2.1/t100801-c548-ln-ht-02-b-ag-expected.txt:
* platform/gtk/css2.1/t1507-c526-font-sz-02-b-a-expected.png:
* platform/gtk/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
* platform/gtk/css2.1/t1601-c547-indent-00-b-a-expected.png:
* platform/gtk/css2.1/t1601-c547-indent-00-b-a-expected.txt:
* platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.png:
* platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt:
* platform/gtk/editing/selection/caret-ltr-2-expected.png:
* platform/gtk/editing/selection/caret-ltr-2-expected.txt:
* platform/gtk/editing/selection/caret-ltr-2-left-expected.png:
* platform/gtk/editing/selection/caret-ltr-2-left-expected.txt:
* platform/gtk/editing/selection/caret-ltr-expected.png:
* platform/gtk/editing/selection/caret-ltr-expected.txt:
* platform/gtk/editing/selection/caret-ltr-right-expected.png:
* platform/gtk/editing/selection/caret-ltr-right-expected.txt:
* platform/gtk/editing/selection/caret-rtl-2-expected.png:
* platform/gtk/editing/selection/caret-rtl-2-expected.txt:
* platform/gtk/editing/selection/caret-rtl-2-left-expected.png:
* platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
* platform/gtk/editing/selection/caret-rtl-expected.png:
* platform/gtk/editing/selection/caret-rtl-expected.txt:
* platform/gtk/editing/selection/caret-rtl-right-expected.png:
* platform/gtk/editing/selection/caret-rtl-right-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-1-expected.png:
* platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-2-expected.png:
* platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-3-expected.png:
* platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-4-expected.png:
* platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-5-expected.png:
* platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
* platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
* platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
* platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
* platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
* platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
* platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
* platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
* platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.png:
* platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt:
* platform/gtk/fast/css/ex-after-font-variant-expected.png:
* platform/gtk/fast/css/ex-after-font-variant-expected.txt:
* platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt:
* platform/gtk/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
* platform/gtk/fast/forms/minWidthPercent-expected.png:
* platform/gtk/fast/forms/minWidthPercent-expected.txt:
* platform/gtk/fast/lists/008-expected.png:
* platform/gtk/fast/lists/008-expected.txt:
* platform/gtk/fast/lists/008-vertical-expected.png:
* platform/gtk/fast/lists/008-vertical-expected.txt:
* platform/gtk/fast/overflow/overflow-rtl-expected.png:
* platform/gtk/fast/overflow/overflow-rtl-expected.txt:
* platform/gtk/fast/overflow/overflow-rtl-vertical-expected.png:
* platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt:
* platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.png:
* platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
* platform/gtk/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
* platform/gtk/svg/custom/alignment-baseline-modes-expected.png:
* platform/gtk/svg/custom/alignment-baseline-modes-expected.txt:
* platform/gtk/svg/custom/dominant-baseline-modes-expected.png:
* platform/gtk/svg/custom/dominant-baseline-modes-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55527-expected.png:
* platform/gtk/tables/mozilla/bugs/bug55527-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
108 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/gtk/css1/font_properties/font_size-expected.png
LayoutTests/platform/gtk/css1/font_properties/font_size-expected.txt
LayoutTests/platform/gtk/css1/text_properties/letter_spacing-expected.png
LayoutTests/platform/gtk/css1/text_properties/letter_spacing-expected.txt
LayoutTests/platform/gtk/css1/text_properties/line_height-expected.png
LayoutTests/platform/gtk/css1/text_properties/line_height-expected.txt
LayoutTests/platform/gtk/css1/text_properties/text_indent-expected.png
LayoutTests/platform/gtk/css1/text_properties/text_indent-expected.txt
LayoutTests/platform/gtk/css1/text_properties/word_spacing-expected.png
LayoutTests/platform/gtk/css1/text_properties/word_spacing-expected.txt
LayoutTests/platform/gtk/css1/units/length_units-expected.png
LayoutTests/platform/gtk/css1/units/length_units-expected.txt
LayoutTests/platform/gtk/css2.1/t040302-c61-ex-len-00-b-a-expected.png
LayoutTests/platform/gtk/css2.1/t040302-c61-ex-len-00-b-a-expected.txt
LayoutTests/platform/gtk/css2.1/t040302-c61-rel-len-00-b-ag-expected.png
LayoutTests/platform/gtk/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt
LayoutTests/platform/gtk/css2.1/t1008-c44-ln-box-02-d-ag-expected.png
LayoutTests/platform/gtk/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt
LayoutTests/platform/gtk/css2.1/t100801-c544-valgn-01-d-ag-expected.png
LayoutTests/platform/gtk/css2.1/t100801-c544-valgn-01-d-ag-expected.txt
LayoutTests/platform/gtk/css2.1/t100801-c544-valgn-03-d-agi-expected.png
LayoutTests/platform/gtk/css2.1/t100801-c544-valgn-03-d-agi-expected.txt
LayoutTests/platform/gtk/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png
LayoutTests/platform/gtk/css2.1/t100801-c548-ln-ht-02-b-ag-expected.txt
LayoutTests/platform/gtk/css2.1/t1507-c526-font-sz-02-b-a-expected.png
LayoutTests/platform/gtk/css2.1/t1507-c526-font-sz-02-b-a-expected.txt
LayoutTests/platform/gtk/css2.1/t1601-c547-indent-00-b-a-expected.png
LayoutTests/platform/gtk/css2.1/t1601-c547-indent-00-b-a-expected.txt
LayoutTests/platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.png
LayoutTests/platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt
LayoutTests/platform/gtk/editing/selection/caret-ltr-2-expected.png
LayoutTests/platform/gtk/editing/selection/caret-ltr-2-expected.txt
LayoutTests/platform/gtk/editing/selection/caret-ltr-2-left-expected.png
LayoutTests/platform/gtk/editing/selection/caret-ltr-2-left-expected.txt
LayoutTests/platform/gtk/editing/selection/caret-ltr-expected.png
LayoutTests/platform/gtk/editing/selection/caret-ltr-expected.txt
LayoutTests/platform/gtk/editing/selection/caret-ltr-right-expected.png
LayoutTests/platform/gtk/editing/selection/caret-ltr-right-expected.txt
LayoutTests/platform/gtk/editing/selection/caret-rtl-2-expected.png
LayoutTests/platform/gtk/editing/selection/caret-rtl-2-expected.txt
LayoutTests/platform/gtk/editing/selection/caret-rtl-2-left-expected.png
LayoutTests/platform/gtk/editing/selection/caret-rtl-2-left-expected.txt
LayoutTests/platform/gtk/editing/selection/caret-rtl-expected.png
LayoutTests/platform/gtk/editing/selection/caret-rtl-expected.txt
LayoutTests/platform/gtk/editing/selection/caret-rtl-right-expected.png
LayoutTests/platform/gtk/editing/selection/caret-rtl-right-expected.txt
LayoutTests/platform/gtk/editing/selection/select-across-readonly-input-1-expected.png
LayoutTests/platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt
LayoutTests/platform/gtk/editing/selection/select-across-readonly-input-2-expected.png
LayoutTests/platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt
LayoutTests/platform/gtk/editing/selection/select-across-readonly-input-3-expected.png
LayoutTests/platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt
LayoutTests/platform/gtk/editing/selection/select-across-readonly-input-4-expected.png
LayoutTests/platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt
LayoutTests/platform/gtk/editing/selection/select-across-readonly-input-5-expected.png
LayoutTests/platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt
LayoutTests/platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png
LayoutTests/platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt
LayoutTests/platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png
LayoutTests/platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt
LayoutTests/platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png
LayoutTests/platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt
LayoutTests/platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png
LayoutTests/platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt
LayoutTests/platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png
LayoutTests/platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt
LayoutTests/platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png
LayoutTests/platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt
LayoutTests/platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png
LayoutTests/platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt
LayoutTests/platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png
LayoutTests/platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt
LayoutTests/platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png
LayoutTests/platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt
LayoutTests/platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png
LayoutTests/platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt
LayoutTests/platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.png
LayoutTests/platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt
LayoutTests/platform/gtk/fast/css/ex-after-font-variant-expected.png
LayoutTests/platform/gtk/fast/css/ex-after-font-variant-expected.txt
LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt
LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt
LayoutTests/platform/gtk/fast/forms/minWidthPercent-expected.png
LayoutTests/platform/gtk/fast/forms/minWidthPercent-expected.txt
LayoutTests/platform/gtk/fast/lists/008-expected.png
LayoutTests/platform/gtk/fast/lists/008-expected.txt
LayoutTests/platform/gtk/fast/lists/008-vertical-expected.png
LayoutTests/platform/gtk/fast/lists/008-vertical-expected.txt
LayoutTests/platform/gtk/fast/overflow/overflow-rtl-expected.png
LayoutTests/platform/gtk/fast/overflow/overflow-rtl-expected.txt
LayoutTests/platform/gtk/fast/overflow/overflow-rtl-vertical-expected.png
LayoutTests/platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt
LayoutTests/platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.png
LayoutTests/platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.txt
LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png
LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt
LayoutTests/platform/gtk/svg/W3C-SVG-1.1/coords-units-03-b-expected.png
LayoutTests/platform/gtk/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt [new file with mode: 0644]
LayoutTests/platform/gtk/svg/custom/alignment-baseline-modes-expected.png
LayoutTests/platform/gtk/svg/custom/alignment-baseline-modes-expected.txt
LayoutTests/platform/gtk/svg/custom/dominant-baseline-modes-expected.png
LayoutTests/platform/gtk/svg/custom/dominant-baseline-modes-expected.txt
LayoutTests/platform/gtk/tables/mozilla/bugs/bug55527-expected.png
LayoutTests/platform/gtk/tables/mozilla/bugs/bug55527-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp