2009-02-13 Darin Adler <darin@apple.com>
authordarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 13 Feb 2009 23:56:43 +0000 (23:56 +0000)
committerdarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 13 Feb 2009 23:56:43 +0000 (23:56 +0000)
commit9de2366d28135c90a917dc161c0064d5b557a495
treec02c8de953c822b7902460c0b254ccb1c52a41d8
parent7803989f505fead6deb0339b97e064af55c0b323
2009-02-13  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Fix broken tokenizer regression test that reflected a lifetime bug
        in the document.write optimization. The test failure was trivial to
        reproduce in COLLECT_ON_EVERY_ALLOCATION mode.

        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::documentWrite): Convert strings to String rather than passing
        the pointer and length to SegmentedString. The optimization is thus
        mostly gone. However, there are two ways to bring it back: 1) Apply
        the patch that makes UString and String share the same buffers.
        2) Add a UString feature to SegmentedString; simple to do but might
        risk slowing down normal document parsing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore/ChangeLog
WebCore/bindings/js/JSHTMLDocumentCustom.cpp