2011-06-21 Dirk Schulze <krit@webkit.org>
authorkrit@webkit.org <krit@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 21 Jun 2011 18:14:12 +0000 (18:14 +0000)
committerkrit@webkit.org <krit@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 21 Jun 2011 18:14:12 +0000 (18:14 +0000)
commit9b4dbb2a6e75d587069d982a070a92504bc1a02e
treee5cb46a4d09cfb75e5f713f8b4034816c8835843
parent048c6e07fc1237e13f6c979f005b1ae969c11374
2011-06-21  Dirk Schulze  <krit@webkit.org>

        Reviewed by Rob Buis.

        SVG no fallback to discrete animation on attribute 'values' for SVGString
        https://bugs.webkit.org/show_bug.cgi?id=57085

        Check for AnimatedString, AnimatedBoolean and AnimatedEnumeration on 'values' calculation.
        If the property type matches one of the above values, fallback to discrete animation.

        The patch also changes behavior for String animation. The animation code doesn't handle inheritance
        for strings anymore. This is done by the CSS parser itself now, we just need to handle inheritance
        on animations that interpolate between two values like for calcMode="linear".

        Test: svg/animations/svgstring-animation-fallback-to-discrete.html

        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
2011-06-21  Dirk Schulze  <krit@webkit.org>

        Reviewed by Rob Buis.

        SVG no fallback to discrete animation on attribute 'values' for SVGString
        https://bugs.webkit.org/show_bug.cgi?id=57085

        Added new test to check fallback to discrete animations on string values. One
        test needed rebaseline. Even if we do not pass the test it is still a progression.

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
        * svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/svgstring-animation-fallback-to-discrete-expected.txt: Added.
        * svg/animations/svgstring-animation-fallback-to-discrete.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png
LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt
LayoutTests/svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js [new file with mode: 0644]
LayoutTests/svg/animations/svgstring-animation-fallback-to-discrete-expected.txt [new file with mode: 0644]
LayoutTests/svg/animations/svgstring-animation-fallback-to-discrete.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/svg/SVGAnimateElement.cpp
Source/WebCore/svg/SVGAnimateElement.h
Source/WebCore/svg/SVGAnimationElement.cpp