[LFC] Miscellaneous fixes to fix simple absolute positioning.
authorzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 23 Jun 2018 14:38:32 +0000 (14:38 +0000)
committerzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 23 Jun 2018 14:38:32 +0000 (14:38 +0000)
commit9b3bc7fff4074ad80d1181f644012f83ec01e62c
tree3be14d9be826dc8d2bb53e0b94560a3cf14065b1
parent3a01824369095f150eb58175bbe08868ee7a91b7
[LFC] Miscellaneous fixes to fix simple absolute positioning.
https://bugs.webkit.org/show_bug.cgi?id=186962

Reviewed by Antti Koivisto.

1. Collect out-of-flow formatting root descendants.
2. Remove invalid and redundant ASSERTs
  invalid because the assertion is missing border, padding etc.
  redundant becasue we assert on geometry correctness in validateGeometryConstraintsAfterLayout.

* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
* layout/layouttree/LayoutContainer.cpp:
(WebCore::Layout::Container::addOutOfFlowDescendant):
(WebCore::Layout::Container::setOutOfFlowDescendants): Deleted.
* layout/layouttree/LayoutContainer.h:
* layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createSubTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/layout/FormattingContext.cpp
Source/WebCore/layout/layouttree/LayoutContainer.cpp
Source/WebCore/layout/layouttree/LayoutContainer.h
Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp