ASSERTION FAILED: vm->currentThreadIsHoldingAPILock() seen with http/tests/paymentreq...
authoraestes@apple.com <aestes@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Feb 2018 04:10:09 +0000 (04:10 +0000)
committeraestes@apple.com <aestes@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Feb 2018 04:10:09 +0000 (04:10 +0000)
commit9ad2ebe13dccac79ed75d67ed2b1bdd191fb01c4
tree788dfe5d0f72e0bfece5581e9b40a425b5a735c9
parent0dd52aeaf61345cc22580305fe79816714760fb1
ASSERTION FAILED: vm->currentThreadIsHoldingAPILock() seen with http/tests/paymentrequest/payment-request-show-method.https.html
https://bugs.webkit.org/show_bug.cgi?id=182591

Reviewed by Youenn Fablet.

Fixes assertion failures in http/tests/paymentrequest/payment-request-show-method.https.html.

DOMPromise::whenSettled() calls the JSC API without first aquiring the API lock, and
r228195 added a call to whenSettled() where the lock is not guaranteed to be already
acquired.

Fix this by creating a JSLockHolder in DOMPromise::whenSettled().

* bindings/js/JSDOMPromise.cpp:
(WebCore::DOMPromise::whenSettled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@228258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/bindings/js/JSDOMPromise.cpp