top and bottom black background line not getting displayed
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 11 Dec 2013 05:57:01 +0000 (05:57 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 11 Dec 2013 05:57:01 +0000 (05:57 +0000)
commit9a660acd6c9176669048e89c5330b5a611d58fb4
tree3c357951f6ab19673aad160539e6f38c344a97e4
parent5dbc3501b8c07f04bcfc6bdffb43862c021e2104
top and bottom black background line not getting displayed
https://bugs.webkit.org/show_bug.cgi?id=21664

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-12-10
Reviewed by Simon Fraser.

Source/WebCore:

The table cell's background was not being displayed. Since the table
cell had no child correct offsetWidth was not being set even if table
width is being defined.

Test: fast/dom/HTMLTableElement/empy-table-cell-with-background-color.html

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
cellHasContent should also be set to true incase background color is
present.

LayoutTests:

* fast/dom/HTMLTableElement/empy-table-cell-with-background-color-expected.txt: Added.
* fast/dom/HTMLTableElement/empy-table-cell-with-background-color.html: Added.
Added new test case to verify that table cell offsetWidth is set even
when it has no contents but has background color.
* fast/table/auto-100-percent-width-expected.txt:
* platform/mac/fast/table/empty-cells-expected.txt:
* tables/mozilla/bugs/bug1818-6-expected.txt:
Rebaselining the existing test case as per the new changes. The new
dimension changes are as per mozilla behaviour. For
auto-100-percent-width-expected.txt we get 1 px red background because
if cellHasContent we set columnLayout's minLogicalWidth and
columnLayout's maxLogicalWidth as 1 initially even if cell is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@160410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/dom/HTMLTableElement/empy-table-cell-with-background-color-expected.txt [new file with mode: 0755]
LayoutTests/fast/dom/HTMLTableElement/empy-table-cell-with-background-color.html [new file with mode: 0755]
LayoutTests/fast/table/auto-100-percent-width-expected.txt
LayoutTests/platform/mac/fast/table/empty-cells-expected.txt
LayoutTests/tables/mozilla/bugs/bug1818-6-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/rendering/AutoTableLayout.cpp