flexbox scrollbars don't take flex-direction into account
authortony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Jan 2012 18:12:05 +0000 (18:12 +0000)
committertony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Jan 2012 18:12:05 +0000 (18:12 +0000)
commit999ccbfcac52403380f9197ab2db4e15c68bd36c
treecfd4598c9ae59533dbdfd8724988b5c82cd0036c
parent8db992a83b0986c5e5a3d94a2ca8e271bc17c184
flexbox scrollbars don't take flex-direction into account
https://bugs.webkit.org/show_bug.cgi?id=70772

Reviewed by Darin Adler.

Source/WebCore:

This fixes a bug where we always used the logicalScrollbarHeight.
For column flow, this was incorrect.

Also fix a bug where we didn't include the trailing border+padding+scrollbar when computing the
height of a column flow.

Tests: css3/flexbox/cross-axis-scrollbar-expected.html
       css3/flexbox/cross-axis-scrollbar.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::crossAxisScrollbarExtent): Add a direction aware method for getting the scrollbar size.
(WebCore):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Use crossAxisScrollbarExtent.
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/cross-axis-scrollbar-expected.html: Added.
* css3/flexbox/cross-axis-scrollbar.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/css3/flexbox/cross-axis-scrollbar-expected.html [new file with mode: 0644]
LayoutTests/css3/flexbox/cross-axis-scrollbar.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderFlexibleBox.cpp
Source/WebCore/rendering/RenderFlexibleBox.h