Replace 2 uses of updateLogicalHeight with computeLogicalHeight
authortony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 8 Oct 2012 21:16:27 +0000 (21:16 +0000)
committertony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 8 Oct 2012 21:16:27 +0000 (21:16 +0000)
commit9920b480f1bd857a1fed0a7ddb9ad74d0719eac8
tree274351caf6fd2b8a027f359dc066cca692a4f486
parent9ae88b6de10f3a673918614858aafcbf344bd605
Replace 2 uses of updateLogicalHeight with computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=98677

Reviewed by Ojan Vafai.

This is part of bug 96804.  Convert RenderTextControl and RenderSVGForeignObject to
override the const computeLogicalHeight method rather than the updateLogicalHeight
setter method.

No new tests, there should be no behavior change as this is just a refactor.

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight): Pass logicalHeight through rather than setting height.
This is a slight correctness fix, although we don't support vertical inputs yet.
* rendering/RenderTextControl.h:
(RenderTextControl):
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::computeLogicalHeight):
* rendering/svg/RenderSVGForeignObject.h:
(RenderSVGForeignObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderTextControl.cpp
Source/WebCore/rendering/RenderTextControl.h
Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp
Source/WebCore/rendering/svg/RenderSVGForeignObject.h