Many webkitpy unit tests can be run standalone, are executable
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Dec 2012 20:34:15 +0000 (20:34 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Dec 2012 20:34:15 +0000 (20:34 +0000)
commit97a9406566c822c1dbd01c0f344fcedafb7dc485
treeb8275fb3464d0f6cbdc10196fb2f263f60f46561
parent4fcb3fe9d701a57f99c2896f57bc45c063d18bde
Many webkitpy unit tests can be run standalone, are executable
https://bugs.webkit.org/show_bug.cgi?id=103900

Reviewed by Eric Seidel.

There's no need anymore to run unit tests in standalone mode as they
are now handled by test-webkitpy in a formidable fashion. This makes
it possible for this patch to remove the following unnecessary bits:
- remove shebang lines from unit test files,
- remove calls to unittest.main(),
- make unit test files non-executable.

* Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
(DiffParserTest.test_git_mnemonicprefix):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(GitTestWithMock.test_push_local_commits_to_server_without_username_and_with_password):
* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest.test_should_build):
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_chromium_xvfb_port):
* Scripts/webkitpy/common/find_files_unittest.py:
(TestWinNormalize.test_win):
* Scripts/webkitpy/common/lru_cache_unittest.py:
(LRUCacheTest.test_set_again):
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(test_results_zip_url):
* Scripts/webkitpy/common/net/credentials_unittest.py:
(test_keyring_without_git_repo_nor_keychain):
* Scripts/webkitpy/common/net/omahaproxy_unittest.py:
(OmahaProxyTest.test_get_revisions):
* Scripts/webkitpy/common/net/unittestresults_unittest.py:
* Scripts/webkitpy/common/newstringio_unittest.py:
(NewStringIOTest.test_with):
* Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
(ReadChecksumFromPngTest.test_read_checksum):
* Scripts/webkitpy/common/system/file_lock_integrationtest.py:
* Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
(MockFileSystemTest.test_normpath):
* Scripts/webkitpy/common/system/filesystem_unittest.py:
(RealFileSystemTest.test_sep):
* Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_total_bytes_memory):
* Scripts/webkitpy/common/system/zipfileset_unittest.py:
(ZipFileSetTest.test_namelist):
* Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
* Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_reftest_diff_image):
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
(JSONGeneratorTest.test_test_timings_trie):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(TestExpectationSerializationTests.test_string_whitespace_stripping):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(KeyCompareTest.test_test_key):
* Scripts/webkitpy/layout_tests/port/builders_unittest.py:
(BuildersTest.test_path_from_name):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortLoggingTest.test_check_sys_deps):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortLoggingTest.test_check_sys_deps):
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.test_default_configuration__scripterror):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_start_actually_starts):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_get_from_builder_name):
* Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
* Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
* Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.disabled_test_mac_lion):
* Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
* Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(VerboseTest.test_log_args):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(test_details):
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTestFactory.test_inspector_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_parse_args):
* Scripts/webkitpy/style/checker_unittest.py:
* Scripts/webkitpy/style/checkers/changelog_unittest.py:
(ChangeLogCheckerTest.test_no_error):
* Scripts/webkitpy/style/checkers/common_unittest.py:
(TabCheckerTest.test_tab):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppCheckerTest.test_ne):
* Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
* Scripts/webkitpy/style/checkers/png_unittest.py:
(PNGCheckerTest.test_check):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
* Scripts/webkitpy/style/checkers/text_unittest.py:
(TextCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/watchlist_unittest.py:
* Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
(XcodeProjectFileCheckerTest.test_detect_development_region):
* Scripts/webkitpy/style/checkers/xml_unittest.py:
(XMLCheckerTest.test_no_error):
* Scripts/webkitpy/style/patchreader_unittest.py:
* Scripts/webkitpy/test/finder_unittest.py:
(FinderTest.test_paths):
* Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.test_run):
* Scripts/webkitpy/test/skip_unittest.py:
(SkipTest.test_skip_if_true):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_imports):
* Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
(TestTranslation.test_include_rewriting):
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(QueueEngineTest.tearDown):
* Scripts/webkitpy/tool/grammar_unittest.py:
(GrammarTest.test_join_with_separators):
* Scripts/webkitpy/tool/mocktool_unittest.py:
(MockOptionsTest.test_kwarg__set):
* Scripts/webkitpy/tool/multicommandtool_unittest.py:
(test_command_help):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
62 files changed:
Tools/ChangeLog
Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py
Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
Tools/Scripts/webkitpy/common/config/build_unittest.py
Tools/Scripts/webkitpy/common/config/ports_unittest.py
Tools/Scripts/webkitpy/common/find_files_unittest.py
Tools/Scripts/webkitpy/common/lru_cache_unittest.py
Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py
Tools/Scripts/webkitpy/common/net/credentials_unittest.py
Tools/Scripts/webkitpy/common/net/omahaproxy_unittest.py
Tools/Scripts/webkitpy/common/net/unittestresults_unittest.py
Tools/Scripts/webkitpy/common/newstringio_unittest.py
Tools/Scripts/webkitpy/common/read_checksum_from_png_unittest.py
Tools/Scripts/webkitpy/common/system/file_lock_integrationtest.py
Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py
Tools/Scripts/webkitpy/common/system/filesystem_unittest.py
Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py
Tools/Scripts/webkitpy/common/system/zipfileset_unittest.py
Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py
Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py
Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/builders_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py
Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/http_lock_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py [changed mode: 0755->0644]
Tools/Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py [changed mode: 0755->0644]
Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py
Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py
Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py [changed mode: 0755->0644]
Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py [changed mode: 0755->0644]
Tools/Scripts/webkitpy/style/checker_unittest.py [changed mode: 0755->0644]
Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py
Tools/Scripts/webkitpy/style/checkers/common_unittest.py
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Tools/Scripts/webkitpy/style/checkers/jsonchecker_unittest.py [changed mode: 0755->0644]
Tools/Scripts/webkitpy/style/checkers/png_unittest.py
Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py
Tools/Scripts/webkitpy/style/checkers/text_unittest.py
Tools/Scripts/webkitpy/style/checkers/watchlist_unittest.py
Tools/Scripts/webkitpy/style/checkers/xcodeproj_unittest.py
Tools/Scripts/webkitpy/style/checkers/xml_unittest.py
Tools/Scripts/webkitpy/style/patchreader_unittest.py
Tools/Scripts/webkitpy/test/finder_unittest.py
Tools/Scripts/webkitpy/test/runner_unittest.py
Tools/Scripts/webkitpy/test/skip_unittest.py
Tools/Scripts/webkitpy/thirdparty/__init___unittest.py
Tools/Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py
Tools/Scripts/webkitpy/tool/bot/queueengine_unittest.py
Tools/Scripts/webkitpy/tool/grammar_unittest.py
Tools/Scripts/webkitpy/tool/mocktool_unittest.py
Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py